Feature/transaction fuel #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetran
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
This looks good, I appreciate the cleanup of the block references and the new api namespace.
My understanding of the major functional changes are threading the fuel tracker through the transact pipeline, the head of which is now in a new namespace. The tracker tracks how many flakes are created.
There was also the addition of the transact! function to the top-level api, which is a nice convenience.
You're right! I forgot about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds fuel tracking to transactions using the fuel-tracker infrastructure implemented previously for queries, and removes auto-generation of
[* ":rdf/type" ":rdfs/Class"]flakes for new iris immediately used as classes in a transaction for consistency and explicitness.There is also more cleanup to remove some references to the legacy
:blockdb field that's no longer used, as well as removing the obsoletefluree.db.query.schemanamespace.Closes #242