Fix/subject object scans #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mpoffald
approved these changes
Jul 24, 2023
| @@ -222,3 +222,38 @@ | |||
| :schema/name "Brian"}]} | |||
| subject) | |||
| "returns all results in a map keyed by alias."))))) | |||
|
|
|||
| (deftest ^:integration subject-object-test | |||
There was a problem hiding this comment.
Since this is meant to fix deletion as reported in https://github.com/fluree/core/issues/18, could we also get a corresponding test in update-test ns?
src/fluree/db/query/exec/where.cljc
Outdated
| in an object pattern under the `::fn` key (if any) by also checking if a | ||
| prospective flake object is equal to the supplied `o` value if and only if the | ||
| `:spot` index is used, the `p` value is `nil`, and the `s` and `o` values are | ||
| not `nil`b. In this case, the new object value returned by this function will |
There was a problem hiding this comment.
Little typo in the second sentence of the docstring:
" not nilb. " has an extraneous "b" at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch scans all the flakes for a subject in the spot index and filters those flakes by object in the case we know the subject and object values to match against but do not know the predicate. This ensures we consider every flake necessary. Otherwise, we could skip some flakes depending on the structure of the underlying sorted set and which flakes it branches on.
This batch depends on #536, so please review that first.
Really Fixes fluree/core#18