Feature/sparql from named #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetran
reviewed
May 23, 2024
| [[_ source]] | ||
| [[:from (parse-term source)]]) | ||
| ;; DatasetClause ::= FromClause* | ||
| ;; FromClause ::= <'FROM'> WS ( DefaultGraphClause | NamedGraphClause ) |
There was a problem hiding this comment.
Can you add angle brackets around the left hand side FromClause term to match the bnf file?
dpetran
force-pushed
the
feature/sparql-func
branch
from
3689f24
to
76d9d7c
Compare
dpetran
force-pushed
the
feature/sparql-from-named
branch
from
2831dba
to
b6f6774
Compare
|
Rebased on #778 |
dpetran
force-pushed
the
feature/sparql-func
branch
2 times, most recently
from
b62ad15
to
63090d7
Compare
dpetran
force-pushed
the
feature/sparql-from-named
branch
from
b6f6774
to
b1e33fa
Compare
|
Rebased on #778 |
dpetran
force-pushed
the
feature/sparql-func
branch
from
63090d7
to
968aedd
Compare
dpetran
force-pushed
the
feature/sparql-from-named
branch
from
b1e33fa
to
25c82b9
Compare
The grammar wasn't expecting whitespace between the 'a' and the prev/next term.
Semantics and syntax from SPARQL IN expression.
It's not sparql-specific, so no need to qualify it.
The :Expression parser was turning everything into a string, which works in some cases but introduces unwanted quoting in others. By deferring stringification until values need to be incorporated into an actual string expression we avoid the unwanted quoting. Do note that all the numeric functions now correctly expect numeric values instead of strings.
abs expects only a single expression as an argument, and that argument does not need to be quoted.
translate SPARQL IN/NOT IN expresssions into FQL
translate SPARQL EXISTS/NOT EXISTS filters into FQL
add support for `in` expression
Feature/fql exists not exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for translating SPARQL
FROMandFROM NAMEDclauses to FQL.