Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include opts in SPARQL queries #800

Merged
merged 21 commits into from
Jul 22, 2024
Merged

Include opts in SPARQL queries #800

merged 21 commits into from
Jul 22, 2024

Conversation

JaceRockman
Copy link
Contributor

@JaceRockman JaceRockman commented Jun 5, 2024 •
edited
Loading

Allow opts to be added to SPARQL queries for credential purposes.

@JaceRockman JaceRockman marked this pull request as ready for review June 12, 2024 19:53
@JaceRockman JaceRockman requested a review from a team July 1, 2024 20:43
@bplatz
Copy link
Contributor

bplatz commented Jul 8, 2024

Is this still desired, or should this be closed?

@JaceRockman
Copy link
Contributor Author

Is this still desired, or should this be closed?

I think we want to be able to restrict SPARQL queries by role still. Why would we no longer want that?

@bplatz
Copy link
Contributor

bplatz commented Jul 8, 2024

I think we want to be able to restrict SPARQL queries by role still. Why would we no longer want that?

That sounds good. The new policy-queries no longer has roles, there is the new wrap-identity-policy API which would be the closest approximation to this.

@JaceRockman JaceRockman force-pushed the feature/sparql-query-policy-handling branch from 23c1bfa to 76ce505 Compare July 9, 2024 20:32
@JaceRockman JaceRockman force-pushed the feature/sparql-query-policy-handling branch from 1b5a4d6 to ffddf05 Compare July 16, 2024 14:41
dpetran
dpetran reviewed Jul 17, 2024
View reviewed changes
src/clj/fluree/db/api.cljc Outdated Show resolved Hide resolved
@JaceRockman JaceRockman mentioned this pull request Jul 19, 2024
Closed
@JaceRockman JaceRockman changed the title Add request-opts to the query opts Include opts in SPARQL queries Jul 19, 2024
bplatz
bplatz reviewed Jul 19, 2024
View reviewed changes
src/clj/fluree/db/api.cljc Outdated Show resolved Hide resolved
bplatz
bplatz reviewed Jul 19, 2024
View reviewed changes
src/clj/fluree/db/api.cljc Outdated Show resolved Hide resolved
bplatz
bplatz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@bplatz bplatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bplatz bplatz mentioned this pull request Jul 20, 2024
Merged
@JaceRockman JaceRockman merged commit 6fcb280 into main Jul 22, 2024
7 checks passed
@JaceRockman JaceRockman deleted the feature/sparql-query-policy-handling branch July 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpetran dpetran dpetran left review comments

@bplatz bplatz bplatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaceRockman @bplatz @dpetran