Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for layer zoom limits #934

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Add support for layer zoom limits #934

merged 1 commit into from
Mar 8, 2022

Conversation

morvagergely
Copy link
Contributor

Added support for layer properties minzoom and maxzoom.
I also updated the layer example and added the minzoom property for the "moving" layer.

Copy link
Collaborator

@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - was planning to do this as well

ios/Classes/MapboxMapController.swift Outdated Show resolved Hide resolved
ios/Classes/MapboxMapController.swift Outdated Show resolved Hide resolved
@felix-ht
Copy link
Collaborator

felix-ht commented Mar 4, 2022

Please also run the formatting scripts for java and swift (check the flutter_ci.yml for details)

@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN March 4, 2022 10:13 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN March 4, 2022 10:13 Inactive
@felix-ht
Copy link
Collaborator

felix-ht commented Mar 8, 2022

swift is still failing the source LGTM besides that -> run swiftformat --swiftversion 4.2 --maxwidth 100 ios

@morvagergely
Copy link
Contributor Author

swift is still failing the source LGTM besides that -> run swiftformat --swiftversion 4.2 --maxwidth 100 ios

I ran this exact command on a macbook and it modified the OfflinePackDownloadManager.swift file. This seemed to be the only file that failed. I reverted this change, so it will hopefully be okay now.

@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN March 8, 2022 14:03 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN March 8, 2022 14:03 Inactive
@felix-ht felix-ht merged commit 4867ed7 into flutter-mapbox-gl:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants