Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please expose session_timers_refresh_method via UASettings #376

Closed
komaxx opened this issue Jun 14, 2023 · 0 comments · Fixed by #377
Closed

Please expose session_timers_refresh_method via UASettings #376

komaxx opened this issue Jun 14, 2023 · 0 comments · Fixed by #377

Comments

@komaxx
Copy link
Contributor

komaxx commented Jun 14, 2023

Is your feature request related to a problem? Please describe.
A server I have to work with does not accept the default SipMethod.UPDATE message type to keep a connection alive. Instead, my app is required to send new INVITE messages.

Describe the solution you'd like
It would be great when a new field SipMethod sessionTimersRefreshMethod would be added to UaSettings. That way, apps could still use the (very helpful) SipUaHelper class and adapt the refreshing method to what is required by servers.

Describe alternatives you've considered
The only alternatives I can think of are:

  • Get the server to accept UPDATE messages. This is unlikely (third party implementation)
  • Re-implement the SipUaHelper to directly write the Settings that I need. That would be quote cumbersome..
komaxx pushed a commit to komaxx/dart-sip-ua that referenced this issue Jun 14, 2023
…o UaSettings to expose this feature for users of SipUaHelper
cloudwebrtc pushed a commit that referenced this issue Jun 25, 2023
#377)

* #376: Added `_settings.session_timers_refresh_method` to UaSettings to expose this feature for users of SipUaHelper

* Reformatted sip_ua_helper to get build pipeline to run

---------

Co-authored-by: Matthias Schicker <matthias@matthiasschicker.de>
cloudwebrtc pushed a commit that referenced this issue Dec 11, 2023
* #376: Added `_settings.session_timers_refresh_method` to UaSettings to expose this feature for users of SipUaHelper

* Reformatted sip_ua_helper to get build pipeline to run

* Updated some dependencies

* More dependency updates

---------

Co-authored-by: Matthias Schicker <matthias@matthiasschicker.de>
cloudwebrtc pushed a commit that referenced this issue May 28, 2024
* #376: Added `_settings.session_timers_refresh_method` to UaSettings to expose this feature for users of SipUaHelper

* Reformatted sip_ua_helper to get build pipeline to run

* Updated some dependencies

* More dependency updates

* Exposed 'iceTransportPolicy' UaSettings to allow for restricting acceptable ice candidates

* Removed inadvertently added empty lines

---------

Co-authored-by: Matthias Schicker <matthias@matthiasschicker.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant