Updates for Android NDK version 26 #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Feb 5, 2024
build/config/android/config.gni
Outdated
Comment on lines
97
to
99
| if (current_cpu != "x64" && current_cpu != "arm64") { | ||
| android_api_level = 19 | ||
| } |
There was a problem hiding this comment.
I think this needs to stay and get changed to 21. The default above is 22.
dnfield
reviewed
Feb 5, 2024
| @@ -25,22 +16,6 @@ if (is_android) { | |||
| android_sdk_version = default_android_sdk_version | |||
| android_sdk_build_tools_version = default_android_sdk_build_tools_version | |||
|
|
|||
| android_default_keystore_path = | |||
There was a problem hiding this comment.
nit: if you're removing these, maybe remove them from the declare_args block above too?
There was a problem hiding this comment.
Could you clarify? These deletions are the deletions from the declare_args block.
zanderso
force-pushed
the
android-ndk-26
branch
from
bd4cc6e
to
eca7331
Compare
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Feb 7, 2024
This PR adjusts the GN build for a newer Android NDK. It relies on flutter/buildroot#822.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the buildroot for Android NDK version 26. This NDK version only supports clang, so it contains some cleanups of old non-clang pathways.
The companion flutter/engine PR is flutter/engine#48254.