Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced accentColor with colorScheme.secondary #1181

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

HansMuller
Copy link
Contributor

Replaced Theme accentColor dependency with colorScheme.secondary because the accentColor theme properties are going to be deprecated. See flutter/flutter#81336

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Looks like you need to rebase with tip of tree to fix presubmit. Afterwards, you need to add waiting for tree to go green label to submit the PR (Cocoon is experimenting with bot only submissions)

@HansMuller HansMuller added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Apr 28, 2021
@fluttergithubbot fluttergithubbot merged commit ff15344 into flutter:master Apr 28, 2021
@HansMuller HansMuller deleted the deprecate_accent_color branch April 28, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants