Support multiple records for retries on a same task #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,10 @@ class Task extends Document { | |||
| /// | |||
| /// This is a human-readable name, typically a test name (e.g. | |||
| /// "hello_world__memory"). | |||
| String? get taskName => fields!['endTimestamp']!.stringValue!; | |||
There was a problem hiding this comment.
Was this meant to be removed?
There was a problem hiding this comment.
This line is actually a duplicate of https://github.com/flutter/cocoon/pull/3494/files#diff-bb6959c7655c2a5b97a3f09154743dd42d0c9167cb7643bbe51fbeffca9a96e6L91.
Here we are updating it to name (line 97 below).
app_dart/lib/src/request_handlers/postsubmit_luci_subscription.dart
Outdated
Show resolved
Hide resolved
| final String sha = commitKeyId.split('/').last; | ||
| final String documentName = '$kDatabase/documents/tasks/${sha}_${taskName}_1'; | ||
| final String documentName = '$kDatabase/documents/tasks/${sha}_${taskName}_$currentAttempt'; |
There was a problem hiding this comment.
No action: This actually makes the _1 from the previous change make more sense.
keyonghan
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Mistakenly merged in #3494. This PR restores the URL.
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to save multiple entries for a task retry. Old logic overrides task statuses on a single task, which fails to track statuses.
This PR:
attemptsinfocurrent_attempttag to make it easy to trackattemptsinfo.attemptincrease when retry is triggered.Part of flutter/flutter#142951.