Ensure OpacityLayer to have a single child #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ensures that every OpacityLayer can be optimized by retained rendering. Tested with `flutter test --local-engine=host_debug_unopt` in flutter/flutter/packages/flutter. Related issues: flutter#21756 flutter#23535
liyuqian
requested review from
chinmaygarde,
cbracken,
GaryQian and
jason-simmons
chinmaygarde
approved these changes
Mar 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2019
flutter/engine@ca7623e...b75472c git log ca7623e..b75472c --no-merges --oneline b75472c Add missing import to functional for Windows. (flutter/engine#8382) 9d71675 Ensure OpacityLayer to have a single child (flutter/engine#8362) 131cc62 Allow native entrypoint registration for runtime unittests. (flutter/engine#8379) 5e124ff Fix typos (flutter/engine#8339) 972afdc Allow running runtime_unittests in AOT mode. (flutter/engine#8375) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
|
@liyuqian , @chinmaygarde In Should I file an issue in flutter for a review on the Opacity Widget? |
This was referenced Apr 5, 2019
|
@rmarau : the fix should have landed in the master branch. Can you please try to see if it's fixed in your app? |
|
@liyuqian : It is fixed! Thank you. |
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
It ensures that every OpacityLayer can be optimized by retained rendering. Tested with `flutter test --local-engine=host_debug_unopt` in flutter/flutter/packages/flutter. Related issues: flutter#21756 flutter#23535
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 7bafac3.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 7bafac3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ensures that every OpacityLayer can be optimized by retained
rendering.
Tested with
flutter test --local-engine=host_debug_unoptinflutter/flutter/packages/flutter.
Related issues: flutter/flutter#21756 flutter/flutter#23535