Make sure FlutterViewController flushs all pending touches when no longer active #8400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
requested changes
Apr 2, 2019
There was a problem hiding this comment.
From UIEvent documentation:
You should never retain an event object or any object returned from an event object. If you need to retain data outside of the responder method you use to process that data, copy that data from the UITouch or UIEvent object to your local data structures.
|
Thanks. Done. |
chinmaygarde
approved these changes
Apr 4, 2019
| @@ -39,6 +39,7 @@ @implementation FlutterViewController { | |||
| BOOL _initialized; | |||
| BOOL _viewOpaque; | |||
| BOOL _engineNeedsLaunch; | |||
| NSMutableSet* _ongoingTouches; | |||
There was a problem hiding this comment.
Can you please add a type to this or just use an std::set<int64_t> please? Thanks.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2019
…en no longer active (flutter/engine#8400)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2019
flutter/engine@219bf59...8b74cba git log 219bf59..8b74cba --no-merges --oneline 8b74cba Make sure FlutterViewController flushs all pending touches when no longer active (flutter/engine#8400) 06cab81 Roll src/third_party/skia e4628b10722f..51874e3e3712 (2 commits) (flutter/engine#8445) 5460926 Roll src/third_party/dart 9814cb1b9c..896f1c4bb9 (4 commits) 694fc56 Build windows engine on GCE (flutter/engine#8442) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…en no longer active (flutter#8400)" This reverts commit b2a488d.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…en no longer active (flutter#8400)" This reverts commit b2a488d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#30342
Background #6145
@kangwang1988 try this. I wasn't really good at repro'ing but which this patch and your demo project, I can't reproduce the issue anymore.