Roll Dart to 635c47b1c9efe86b896d95bd446c6a5e2459037e. #13315
Conversation
| @@ -1889,7 +1889,7 @@ class _RepositoryBoringSSLDirectory extends _RepositoryDirectory { | |||
| _RepositoryDirectory createSubdirectory(fs.Directory entry) { | |||
| if (entry.name == 'src') | |||
| return _RepositoryBoringSSLSourceDirectory(this, entry); | |||
| return super.createSubdirectory(entry); | |||
| return _RepositoryBoringSSLDirectory(this, entry); | |||
There was a problem hiding this comment.
this looks strange - what is the meaning of this?
There was a problem hiding this comment.
It means that all subdirectories in //third_party/boringssl (except src) are licensed like //third_party/boringssl itself, rather any becoming _RepositoryGenericThirdPartyDirectory.
There was a problem hiding this comment.
hmm.. what if you have another src folder nested deeper in boringssl? With this it will be treated as top-level src, which is rather strange.
635c47b Reland "Update BoringSSL to 4dfd5af." 2be3763 [vm/ffi] Support moves with temp in ffi call 92c69f2 Flow analysis: promote on successful execution of an "as" expression. 6461e41 Flow analysis: call initialize for params after functionExpression_begin. 5837c65 Flow analysis: test unreachability for constructor initializers. 8e23f76 Flow analysis: properly handle promotion of type parameters. a7b092e Fix operator== for type parameter types. 06a8577 Flow analysis: recursively annotate unreachable nodes in test
…er/engine#13315) (#43392) git@github.com:flutter/engine.git/compare/400e3b00fb4c...dcf7b51 git log 400e3b0..dcf7b51 --no-merges --oneline 2019-10-23 rmacnak@google.com Roll Dart to 635c47b1c9efe86b896d95bd446c6a5e2459037e. (flutter/engine#13315) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
|
looking at this on my phone I couldn't figure out what was going on sufficiently to have an opinion. can you find me tomorrow and walk me through it? |
in case it helps to have it written down: |
…er/engine#13315) (flutter#43392) git@github.com:flutter/engine.git/compare/400e3b00fb4c...dcf7b51 git log 400e3b0..dcf7b51 --no-merges --oneline 2019-10-23 rmacnak@google.com Roll Dart to 635c47b1c9efe86b896d95bd446c6a5e2459037e. (flutter/engine#13315) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
635c47b Reland "Update BoringSSL to 4dfd5af."
2be3763 [vm/ffi] Support moves with temp in ffi call
92c69f2 Flow analysis: promote on successful execution of an "as" expression.
6461e41 Flow analysis: call initialize for params after functionExpression_begin.
5837c65 Flow analysis: test unreachability for constructor initializers.
8e23f76 Flow analysis: properly handle promotion of type parameters.
a7b092e Fix operator== for type parameter types.
06a8577 Flow analysis: recursively annotate unreachable nodes in test