Roll dart to 6de2f92033d86b14e05caaa2f276d709ad6a0633. #13278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since last roll: ``` 6de2f92 [vm,bytecode] Allocate objects lazily in bytecode generator 929a306 [tests] Fix missing space in failure message a029172 Fix documentation for InternetAddress.lookup() b942142 [io] add testcases for link pointing to directory 230f48d [vm,aot] Simple unreachable code elimination before type-flow analysis, take 3 e8fa489 [vm/bytecode] Store generated bytecodes more efficiently, add inline pragmas 66ceec0 Fix redirecting constructor const check 6f44e99 [vm/aot] Add test which passes both AOT size information flags --print-instructions-sizes-to/--write-v8-snapshot-profile-to 354921f Update `runtime/docs/aot_binary_size_analysis.md` with paragraph about size comparison tool 5706d13 [dartdevc] Update URI for libraries.json to use multi-root f77d719 [vm/fuzzer] add --enable-asserts to AOT step 199a42f [dartdevc] Cache the results of subtype checks 2495c5c [html] Avoid dynamic in Rectangle operator == aa569df [vm] Enable non-nullable experiment when building platform dill with --nnbd flag. bf4d4b2 [dart/fuzzer] re-enable spread at all depths in fuzzer 13a5893 Update dart_style to 1.3.2. 4e8d517 [vm,bytecode] Store offsets in bytecode declarations, remove putIfAbsent a170fc5 [vm] Fix DirectChainedHashMap iterator 5d4cd6d Breaking changes for analyzer version 0.39. 2423ffe [vm,bytecode] Correct assertion for source positions of yield points d0139e8 [VM] More cleanup in the loader code 73dd5f7 [vm,aot,bytecode] Do not depend on presence of _AsyncAwaitCompleter 7b39f43 [benchmark] Test that precompiler2 --no-gen-bytecode continues to work. ed0cc81 Get DDC and DDK test builds working with the forked NNBD SDK. 6c933a4 [vm] Fix some TSAN failures. Migrate remaining uses of AtomicOperations to std::atomic. c26d596 [flutter] JavaScript support to frontend_server b1b4f6b [cfe] Allow assignment to late final fields/variables f1ac695 [cfe] Handle mixed if map entries 8b3d76d [analyzer/ffi] Fix crash with dynamic field in struct 74d0282 [infra] Run test suites in pkg/front_end/test with custom test runner 6b19f37 [infra] Change option name in modular test runner to be consistent with test.py d0cef92 Migration: refactor logic to match up type parameters between function types. 15ec4a3 [infra] Make front_end tests unapprovable using a blacklist 22dbc7d Migration: FixBuilder support for function expression invocations. 531aaa9 [ddk] Emit variance modifiers for classes, mixins, mixin applications. 064c3c7 Get the DDK build working with NNBD. 57a88fc Reland "[io] exclude links from isDirectory()" 6c36630 Update to latest package:yaml f6eb26d [dart/vm] add ability to pass VM flags to dart when running gen_kernel.dart in precompiler2 script 2c1d405 [changelog/ffi] Document dart:ffi changes for D26 9220890 [vm/bytecode] Do not emit inferred type if unreachable fd0617b Improve listToString and setToString documentation. Fixes flutter#26529 cb9eefc Issue 142793249. Never remove directive with unresolved URIs. 4f0c8cb Add README for samples/sample_extension a9fc9f7 [SDK] Fixes run_appended_aotsnapshot_test on Windows. 22e249d update kernel worker to support -D environment defines ffcfab3 [dartdevc] support null-check bang operator 09b08f7 Add comment on non-negativity of periodic Timer and Stream. 8c041c8 [parser] Don't clear extraneous covariant token 4605011 [vm/compiler] Arm64: Improve StoreIndexedInstr. 3d67e7d [CFE] Don't try to infer fields not in the output program d40c8a0 [kernel] Add 'leakingDebugToString' to nodes 8d8faa7 [SDK] Fixes loading appended snapshots when executed with PATH. c159993 [CFE] Fix crash when serializing: "Type parameter #lib1::B::X is not indexed" b212403 [cfe] Change integer values that encode nullability attributes 9a829cc Remove 'strong' comments from Future. 0c47a85 [CFE] Fix "Type 'void' not found." bug e41086e [vm] Enable timeline trace events with Fuchsia SDK cd95fcc [VM] Start the kernel isolate only when compilations are needed 21972da [analyzer] refactor the flutter assists menu 50f9dd8 Revert "[io] exclude links from isDirectory()" d9fa27a Update ~48 doc comments to have one-sentence summaries 8e7ffaf Reland "[vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions." eb9480d Revert "[vm,aot] Simple unreachable code elimination before type-flow analysis, take 2" 49d743f [io] exclude links from isDirectory() 56991ad [vm,aot] Simple unreachable code elimination before type-flow analysis, take 2 03d6e04 [dart2js] Fix printing of minified closures. 8a92058 Support omitted name args; fix as-expressions, refactor tests 45358c5 [vm] Implementation of NullCheck for bytecode 62283b9 [vm] Bump ABI version to make vm-dartkb-linux-release-x64-abi green again 20f9d4d [vm,bytecode] Omit initialization of delayed type arguments for non-generic closures 1c2dc77 Issue 38947. Support for then/else widgets in ConditionalExpression. d2b39d1 [cfe/ffi] asFunction/fromFunction variance in CFE + regression test 882a6b5 Enable bytecode in AOT compilation pipeline b4ad2f2 [vm/compiler] ARM64: Improve shifts assembly instructions. 9ae7b10 [vm] Fix a bug in Utils::NBitMask. ba728b1 [dartdevc] Copy nnbd subtype test to run on nnbd strong configurations 4dc1901 [vm,bytecode] Write closure attributes separately ecd7977 [vm] Fix gcc build. 411bd62 [isolate] Fix `delete ()` call to operator `delete` form. 00dc546 Migration: make more use of `.isNullAware` throughout migration engine. dce3d05 Migration: Fix three broken FixBuilder unit tests. 8eb28a4 Migration: add simple MethodInvocation support to FixBuilder. 7d4bc6a Fix handling of null awareness in cascade expressions. 4e44906 [VM] Skip verbose_gc_to_bmu_test on precompiled configs ca9671f Migration: add isUpstreamTriggered getter 7eeaead Reland "Update BoringSSL to 4dfd5af." 1f58504 [vm/compiler] Do not initialize delayed_type_arguments_ for non-generic closures 680a880 Move string utils from services/correction to utilities; more generally used ```
|
obsolete |
zanderso
reviewed
Oct 22, 2019
| @@ -1887,12 +1887,46 @@ class _RepositoryBoringSSLDirectory extends _RepositoryDirectory { | |||
|
|
|||
| @override | |||
| _RepositoryDirectory createSubdirectory(fs.Directory entry) { | |||
| if (entry.name == 'src') | |||
| if (entry.name == 'src') { | |||
There was a problem hiding this comment.
It looks like the style in this file is not to use {} for single line ifs.
| } | ||
| } | ||
|
|
||
| class _RepositoryBoringSSLGenCryptoThirdPartyDirectory extends _RepositoryDirectory { |
There was a problem hiding this comment.
Could you explain or add a comment here about what is accomplished by extending _RepositoryDirectory without overriding anything? I'm not familiar with this code, but could what you're trying to do be implemented more transparently by override shouldRecurse somewhere?
|
|
||
| @override | ||
| _RepositoryDirectory createSubdirectory(fs.Directory entry) { | ||
| if (entry.name == 'crypto') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since last roll: