Moves pointer event sanitizing to engine. #13697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
commented
Nov 7, 2019
chunhtai
commented
Nov 7, 2019
chunhtai
force-pushed
the
issues/20517
branch
from
e29c51d
to
1b26aa0
Compare
chunhtai
force-pushed
the
issues/20517
branch
from
1b26aa0
to
fc70ae7
Compare
chunhtai
commented
Nov 8, 2019
| physicalX: packet.getFloat64(kStride * offset++, _kFakeHostEndian), | ||
| physicalY: packet.getFloat64(kStride * offset++, _kFakeHostEndian), | ||
| physicalDeltaX: packet.getFloat64(kStride * offset++, _kFakeHostEndian), | ||
| physicalDeltaY: packet.getFloat64(kStride * offset++, _kFakeHostEndian), |
There was a problem hiding this comment.
Framework move and hover event need delta value. We have to calculate it in the engine, otherwise framework will still need to keep the state which defeat the purpose of this migration
chunhtai
commented
Nov 8, 2019
| buttons: packet.getInt64(kStride * offset++, _kFakeHostEndian), | ||
| obscured: packet.getInt64(kStride * offset++, _kFakeHostEndian) != 0, | ||
| synthesized: packet.getInt64(kStride * offset++, _kFakeHostEndian) != 0, |
There was a problem hiding this comment.
framework need to know if the pointer event is synthesized to be able to correctly calculate the drag velocity.
chunhtai
commented
Nov 13, 2019
| // converted_pointers. | ||
| for (size_t i = 0; i < buffer_length / kBytesPerPointerData; i++) { | ||
| PointerData pointer_data = | ||
| *(reinterpret_cast<PointerData*>(&buffer[i * kBytesPerPointerData])); |
There was a problem hiding this comment.
@chinmaygarde Is this the right way to go? I am not sure what is the standard way to use copy constructor here
There was a problem hiding this comment.
I apologize for my previous comment. I didn't see that the data structure was packed and you were reading from an offset that may not be properly aligned. Your first attempt was better. Please use the memcpy. Sorry for the confusion.
chunhtai
force-pushed
the
issues/20517
branch
from
6d34443
to
06e42a9
Compare
|
@chinmaygarde this is ready for re review |
chinmaygarde
approved these changes
Nov 15, 2019
9 tasks
chunhtai
force-pushed
the
issues/20517
branch
from
06e42a9
to
3edb72e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2019
tvolkert
added a commit
to tvolkert/flutter
that referenced
this pull request
Nov 19, 2019
git@github.com:flutter/engine.git/compare/f4fba66c2fad...c812a62 git log f4fba66..c812a62 --no-merges --oneline 2019-11-19 jonahwilliams@google.com allow ignoring toString, hashCode, and == in api_conform_test (flutter/engine#13907) 2019-11-19 bkonyi@google.com Roll src/third_party/dart d9d5fbc109..eeca3fb1cb (5 commits) 2019-11-19 chinmaygarde@google.com Add virtual destructor to GPUSurfaceSoftwareDelegate. (flutter/engine#13918) 2019-11-19 47866232+chunhtai@users.noreply.github.com Moves pointer event sanitizing to engine. (flutter/engine#13697)
tvolkert
added a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2019
git@github.com:flutter/engine.git/compare/f4fba66c2fad...c812a62 git log f4fba66..c812a62 --no-merges --oneline 2019-11-19 jonahwilliams@google.com allow ignoring toString, hashCode, and == in api_conform_test (flutter/engine#13907) 2019-11-19 bkonyi@google.com Roll src/third_party/dart d9d5fbc109..eeca3fb1cb (5 commits) 2019-11-19 chinmaygarde@google.com Add virtual destructor to GPUSurfaceSoftwareDelegate. (flutter/engine#13918) 2019-11-19 47866232+chunhtai@users.noreply.github.com Moves pointer event sanitizing to engine. (flutter/engine#13697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#44217
flutter/flutter#20517
This pr reimplemeting the sanitizing in engine side.