Adding support for enabling semantics on desktop #14003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
requested review from
yjbanov
and removed request for
franciscojma86
|
This one is not ready for review. I haven't tested on Safari/Mac |
nturgut
changed the title
yjbanov
reviewed
Nov 26, 2019
yjbanov
reviewed
Nov 26, 2019
yjbanov
approved these changes
Nov 26, 2019
mdebbar
reviewed
Nov 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2019
…ine#14003) (#45667) git@github.com:flutter/engine.git/compare/2c0eee43923f...e3e5f8d git log 2c0eee4..e3e5f8d --first-parent --oneline 2019-11-27 50856934+nturgut@users.noreply.github.com Adding support for enabling semantics on desktop (#14003) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only a way of enabling a11y on mobile phones.
This PR adds a way for enabling a11y on desktop.
Work in progress: tests will be added/fixed
Fixes flutter/flutter#45208