Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Fix right click issues #15103

Merged
merged 2 commits into from
Jan 3, 2020
Merged

[web] Fix right click issues #15103

merged 2 commits into from
Jan 3, 2020

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 3, 2020

The main scenarios that this PR fixes:

  1. Two right clicks in a row but in different locations.
  2. Right click then left click in a different location.
  3. Right click then move the mouse quickly (before the context menu pops up).
  4. Start dragging inside the page, and release the mouse outside, then hover back into the page.

Fixes flutter/flutter#47440

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Jan 3, 2020
@mdebbar mdebbar self-assigned this Jan 3, 2020
@auto-assign auto-assign bot requested a review from gw280 January 3, 2020 01:10
@mdebbar mdebbar removed the request for review from gw280 January 3, 2020 01:10
dkwingsmt
dkwingsmt requested changes Jan 3, 2020
View reviewed changes
lib/web_ui/test/engine/pointer_binding_test.dart Show resolved Hide resolved
lib/web_ui/lib/src/engine/pointer_binding.dart Show resolved Hide resolved
lib/web_ui/lib/src/engine/pointer_binding.dart Outdated Show resolved Hide resolved
lib/web_ui/lib/src/engine/pointer_converter.dart Outdated Show resolved Hide resolved
lib/web_ui/test/engine/pointer_binding_test.dart Outdated Show resolved Hide resolved
lib/web_ui/lib/src/engine/pointer_binding.dart Outdated Show resolved Hide resolved
lib/web_ui/test/engine/pointer_binding_test.dart Outdated Show resolved Hide resolved
lib/web_ui/test/engine/pointer_binding_test.dart Outdated Show resolved Hide resolved
lib/web_ui/test/engine/pointer_binding_test.dart Outdated Show resolved Hide resolved
dkwingsmt
dkwingsmt approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar
Copy link
Contributor Author

mdebbar commented Jan 3, 2020

The Fuchsia failure is unrelated to this PR.

@mdebbar mdebbar merged commit eb13993 into flutter:master Jan 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2020
@engine-flutter-autoroll
eb13993 [web] Fix right click issues (flutter/engine#15103)
3034376
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2020
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 3, 2020
@engine-flutter-autoroll
eb13993 [web] Fix right click issues (flutter/engine#15103) (#48143)
a3bbdfb 
flutter/engine@5858519...eb13993

git log 5858519..eb13993 --first-parent --oneline
2020-01-03 mouad.debbar@gmail.com [web] Fix right click issues (flutter/engine#15103)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
kakaka11 added a commit to kakaka11/flutter that referenced this pull request Jan 3, 2020
@kakaka11
Revert "eb139936e [web] Fix right click issues (flutter/engine#15103) (…
87b7928 
…flutter#48143)"

This reverts commit a3bbdfb.
This was referenced Jan 7, 2020
Closed
Closed
Closed
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@mdebbar @filmil
[web] Fix right click issues (flutter#15103)
1dad340
@mdebbar mdebbar mentioned this pull request Apr 8, 2020
Open
@mdebbar mdebbar deleted the fix_state_down branch April 15, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees

@mdebbar mdebbar

Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
4 participants
@mdebbar @dkwingsmt @chunhtai @googlebot