Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use echo to test whether host is up #16322

Merged
merged 2 commits into from Feb 1, 2020
Merged

use echo to test whether host is up #16322

merged 2 commits into from Feb 1, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Feb 1, 2020

I expect this to fail initially - will have to update the failing tests (or figure out why they're failing).

/cc @godofredoc @iskakaushik @gw280

fixes flutter/flutter#49933

@dnfield
Copy link
Contributor Author

dnfield commented Feb 1, 2020

#15116 is where tests started actually failing @abrush21

@dnfield
Copy link
Contributor Author

dnfield commented Feb 1, 2020

https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/3679 is the failing build from before the revert to show that CI is working again with this change

@dnfield
Copy link
Contributor Author

dnfield commented Feb 1, 2020

https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/3680 passed with this change and the revert upstream.

TBR @godofredoc @iskakaushik @gw280

@dnfield dnfield merged commit 3c19eca into flutter:master Feb 1, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Feb 4, 2020
flutter/engine@0816c04...810b9b9

git log 0816c04..810b9b9 --first-parent --oneline
2020-02-03 anna_gringauze@hotmail.com supporting changes for evaluation in web debugger (flutter/engine#16309)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1e316ff39e7..af99f3ee6017 (13 commits) (flutter/engine#16335)
2020-02-03 chinmaygarde@google.com Update buildroot to 02b77827fd4ac639f1c048c6340262cdb4c2a3ab. (flutter/engine#16339)
2020-02-03 chinmaygarde@google.com Disable flaky MessageLoop tests on Fuchsia. (flutter/engine#16340)
2020-02-03 iska.kaushik@gmail.com [fuchsia] Add additional contributing instructions for Googlers (flutter/engine#16337)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/dart ed441e48d055..c8ed304e979a (1 commits) (flutter/engine#16328)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from AtXwP... to Tszo5... (flutter/engine#16334)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d05192abedf..f1e316ff39e7 (3 commits) (flutter/engine#16329)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jtwQF... to 6h3IH... (flutter/engine#16332)
2020-02-03 dnfield@google.com Change NSLog to FML_DLOG (flutter/engine#16331)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5d92ae2b56df..3d05192abedf (1 commits) (flutter/engine#16326)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 776293dceefd..5d92ae2b56df (1 commits) (flutter/engine#16325)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1b80c357926b..776293dceefd (2 commits) (flutter/engine#16324)
2020-02-01 dnfield@google.com use echo to test whether host is up (flutter/engine#16322)
2020-02-01 dnfield@google.com Revert "Modifies accessibility bridge to populate new node fields in semantic… (#15116)" (flutter/engine#16323)
2020-02-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x6sVj... to jtwQF... (flutter/engine#16320)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 91a3ea89c8e4..ed441e48d055 (4 commits) (flutter/engine#16319)
2020-02-01 chinmaygarde@google.com Remove all uses of the redundant flutter_root variable. (flutter/engine#16311)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4513cdde4912..1b80c357926b (1 commits) (flutter/engine#16318)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 5ae5aff6406a..91a3ea89c8e4 (22 commits) (flutter/engine#16310)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VMcGV... to AtXwP... (flutter/engine#16308)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants