Change NSLog to FML_DLOG #16331
Merged
Change NSLog to FML_DLOG #16331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested changes
Feb 3, 2020
There was a problem hiding this comment.
We don't use FML in the desktop embeddings; they are built on the embedder API, not directly on arbitrary engine code like iOS and Android. I assume this is header-only since it compiled, but I don't want to muddy the line of what code is allowed.
We should just remove the logging; someone interested in this while developing can easily add a log locally.
|
Done |
dnfield
added
the
waiting for tree to go green
|
Status lies -tree is green. This is also very safe to land. Landing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
This was referenced Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
This was referenced Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
This was referenced Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 4, 2020
flutter/engine@0816c04...810b9b9 git log 0816c04..810b9b9 --first-parent --oneline 2020-02-03 anna_gringauze@hotmail.com supporting changes for evaluation in web debugger (flutter/engine#16309) 2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1e316ff39e7..af99f3ee6017 (13 commits) (flutter/engine#16335) 2020-02-03 chinmaygarde@google.com Update buildroot to 02b77827fd4ac639f1c048c6340262cdb4c2a3ab. (flutter/engine#16339) 2020-02-03 chinmaygarde@google.com Disable flaky MessageLoop tests on Fuchsia. (flutter/engine#16340) 2020-02-03 iska.kaushik@gmail.com [fuchsia] Add additional contributing instructions for Googlers (flutter/engine#16337) 2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/dart ed441e48d055..c8ed304e979a (1 commits) (flutter/engine#16328) 2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from AtXwP... to Tszo5... (flutter/engine#16334) 2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d05192abedf..f1e316ff39e7 (3 commits) (flutter/engine#16329) 2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jtwQF... to 6h3IH... (flutter/engine#16332) 2020-02-03 dnfield@google.com Change NSLog to FML_DLOG (flutter/engine#16331) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5d92ae2b56df..3d05192abedf (1 commits) (flutter/engine#16326) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 776293dceefd..5d92ae2b56df (1 commits) (flutter/engine#16325) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1b80c357926b..776293dceefd (2 commits) (flutter/engine#16324) 2020-02-01 dnfield@google.com use echo to test whether host is up (flutter/engine#16322) 2020-02-01 dnfield@google.com Revert "Modifies accessibility bridge to populate new node fields in semantic… (#15116)" (flutter/engine#16323) 2020-02-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x6sVj... to jtwQF... (flutter/engine#16320) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 91a3ea89c8e4..ed441e48d055 (4 commits) (flutter/engine#16319) 2020-02-01 chinmaygarde@google.com Remove all uses of the redundant flutter_root variable. (flutter/engine#16311) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4513cdde4912..1b80c357926b (1 commits) (flutter/engine#16318) 2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 5ae5aff6406a..91a3ea89c8e4 (22 commits) (flutter/engine#16310) 2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VMcGV... to AtXwP... (flutter/engine#16308) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 78ff2b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log is confusing for users - the method channel is an optional one. It may still be useful for people developing the engine if they're not sure which methods are and are not handled.
Fixes flutter/flutter#49960