Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uwptool.exe #26038

Merged
merged 1 commit into from
May 11, 2021
Merged

Add uwptool.exe #26038

merged 1 commit into from
May 11, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 8, 2021

uwptool is a helper tool used by the flutter command-line tool. It can
be thought of as analogous to adb for Android or libimobiledevice for
iOS.

Its core functions are:

  • Launch an app with a set of launch arguments. (included in this patch)
  • Install an app (included in a later patch).
  • Uninstall an app (included in a later patch).

Part of flutter/flutter#81756
Part of flutter/flutter#82085

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the issue discussed with the additional app registration reg path required to pick up the dev installed package.

@cbracken
Copy link
Member Author

Registry path updated so we get developer-installed apps in the list now too.

uwptool is a helper tool used by the flutter command-line tool. It can
be thought of as analogous to adb for Android or libimobiledevice for
iOS.

Its core functions are:
* List installed apps. (included in this patch)
* Launch an app with a set of launch arguments. (included in this patch)
* Install an app (included in a later patch).
* Uninstall an app (included in a later patch).

Part of flutter/flutter#81756
@cbracken
Copy link
Member Author

Launch arguments are now working too.

@cbracken cbracken merged commit 807460a into flutter:master May 11, 2021
@cbracken cbracken deleted the uwptool branch May 11, 2021 22:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
cbracken added a commit to cbracken/flutter that referenced this pull request May 12, 2021
flutter/engine@3c93ad4...44ba0c7

2021-05-11 chris@bracken.jp Formatting cleanup for CONTRIBUTING.md
(flutter/engine#26080)
2021-05-11 chris@bracken.jp Add uwptool.exe (flutter/engine#26038)
2021-05-11 bkonyi@google.com Manual SDK roll for DevTools SDK
integration (flutter/engine#26075)
2021-05-11 skia-flutter-autoroll@skia.org Roll Skia from 96bc12d19b9e to
7c328b4b42c5 (5 revisions) (flutter/engine#26071)

2021-05-11 iska.kaushik@gmail.com Unique frame number for each frame
(flutter/engine#26021)

In flutter/engine#26075 we rolled the Dart SDK
to the engine. This included updates to parameter names to Iterable.map
and Iterable.expand which triggers lints about renaming method
parameters in CachingIterable.map and CachingIterable.expand.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
cbracken added a commit to flutter/flutter that referenced this pull request May 12, 2021
flutter/engine@3c93ad4...44ba0c7

2021-05-11 chris@bracken.jp Formatting cleanup for CONTRIBUTING.md
(flutter/engine#26080)
2021-05-11 chris@bracken.jp Add uwptool.exe (flutter/engine#26038)
2021-05-11 bkonyi@google.com Manual SDK roll for DevTools SDK
integration (flutter/engine#26075)
2021-05-11 skia-flutter-autoroll@skia.org Roll Skia from 96bc12d19b9e to
7c328b4b42c5 (5 revisions) (flutter/engine#26071)

2021-05-11 iska.kaushik@gmail.com Unique frame number for each frame
(flutter/engine#26021)

In flutter/engine#26075 we rolled the Dart SDK
to the engine. This included updates to parameter names to Iterable.map
and Iterable.expand which triggers lints about renaming method
parameters in CachingIterable.map and CachingIterable.expand.
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021
uwptool is a helper tool used by the flutter command-line tool. It can
be thought of as analogous to adb for Android or libimobiledevice for
iOS.

Its core functions are:
* List installed apps. (included in this patch)
* Launch an app with a set of launch arguments. (included in this patch)
* Install an app (included in a later patch).
* Uninstall an app (included in a later patch).

Part of flutter/flutter#81756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants