Implement Canvas.drawPoints #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables drawing polygons faster than using Paths. Fixes flutter/flutter#92
abarth
force-pushed
the
draw_points
branch
2 times, most recently
from
1894915
to
411ea5c
Compare
|
lgtm |
| // Draw the entire sequence of point as the vetices of a polygon. | ||
| polygon, | ||
| } | ||
|
|
There was a problem hiding this comment.
would be nice if VertexMode and PointMode discussed when you'd use each one
c.f. http://docs.flutter.io/flutter/dart-ui/BlurStyle-class.html
|
|
Path.fillType Path.addPolygon Path.addPath Path.extendWithPath Path.transform Fixes flutter/flutter#252
|
Getting the following, which seems related to this change: |
|
n/m - just picked up the fix |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
New in this revision: > git log --format="%C(auto) %h %s" b10966c..c00d4b4 c00d4b4 Improve message in `pub outdated` when incompatible versions are found (flutter#2746) 2a17762 outdated --mode=null-safety, resolvable constrained to null-safe vers… (flutter#2739) 3ea2b83 Default language version (flutter#2748) 7886546 Don't allow both --json and --transitive (flutter#2742) Fixes dart-lang/sdk#44013 Change-Id: I0dc876c5e57777a4724d90662408f91910e2517c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171720 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com> Reviewed-by: Michael Thomsen <mit@google.com>
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Added a default language version of 2.7 * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables drawing polygons faster than using Paths.
Fixes flutter/flutter#92