-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add iOS live text input engine side support #34751
Conversation
shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @LongCatIsLooong re: #29229
shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any reason for implementing isLiveTextInputAvailable
in the platform plugin instead of the text input plugin?
Hi @LongCatIsLooong
So I think it is more appropriate to put it in platform plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I merged |
Preview:
normal.video.mp4
Related PR in flutter framework (WIP)
flutter/flutter#96637
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#91896
This PR will let the framework side query the device live text input ability.(See framework PR class
LiveText
)If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].
Pre-launch Checklist
writing and running engine tests.
///
).