Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framework] Add textField OCR support for framework side #96637
[framework] Add textField OCR support for framework side #96637
Changes from all commits
ed104a9
b5cf438
374efed
8691dce
8b46a64
995bdab
5a90f00
7acbb16
5bc7bff
485d282
3911481
dcbf74e
73510c3
c0a5e27
b93d2d1
7490b13
1c99ca2
8111811
dcf051d
feac6bd
e31b97e
da1bec1
402a7bb
5a82003
6068f48
25bcb5b
8f4ee70
e1fdb08
4e9252c
41ac0d5
433a70d
87f9d69
2577715
8eb5e0c
3c97d69
c5b5c93
6d58a9c
2b037a1
eeb1cf5
5e24664
8f6021e
1ae04b5
f9c577c
47ce4f3
e629941
8a16823
b02dc4f
e196c28
53d332b
f07038c
f312e4a
e8b3e2f
d444b4d
850929e
07e7aa9
c3e16c2
79ddee7
78a2964
d34a1f1
b5fef9c
2571aaa
6ea56f7
8416dcd
f845288
0a8baee
779680b
8e0874a
aef841d
857c799
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a common practice in the framework code to include the decimal point for doubles except maybe for "divide by two" like cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are still some doubles without decimal point in this method and possibly elsewhere e.g.:
..lineTo(origin.dx, origin.dy + 1)
canvas.drawLine(const Offset(-3, 0), const Offset(3, 0), _painter);