Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turned on performance-move-const-arg everywhere. #37482

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Turned on performance-move-const-arg everywhere. #37482

merged 6 commits into from
Nov 10, 2022

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Nov 9, 2022 •
edited

fixes: flutter/flutter#113848

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@skia-gold
Copy link

Gold has detected about 72 new digest(s) on patchset 6.
View them at https://flutter-engine-gold.skia.org/cl/github/37482

@gaaclarke gaaclarke marked this pull request as ready for review November 9, 2022 23:28
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #37482 at sha ce82e22

@gaaclarke gaaclarke merged commit f467eee into flutter:main Nov 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
f467eee51 Turned on performance-move-const-arg everywhere. (flutter/e…
0ffdfb3 
…ngine#37482)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 10, 2022
@engine-flutter-autoroll
f467eee51 Turned on performance-move-const-arg everywhere. (flutter/e…
19b351b 
…ngine#37482) (#115095)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 10, 2022
flutter: f467eee51 Turned on performance-move-const-arg everywhere. (f…
10d66dd 
…lutter/engine#37482) (#115095)

Commit: 19b351b072b088f384b0d0f2e895f560cb4451f2
This was referenced Nov 11, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll
19b351b07 f467eee51 Turned on performance-move-const-arg everywhere. (f…
00f9e53 
…lutter/engine#37482) (flutter/flutter#115095)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll
19b351b f467eee51 Turned on performance-move-const-arg everywhere. (f…
02a5ddf 
…lutter/engine#37482) (flutter/flutter#115095)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll
Roll Flutter from c7d1154 to 098aac7 (24 revisions) (#6692)
553dac8 
* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088)

* ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042)

* b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093)

* 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095)

* 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002)

* 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075)

* 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999)

* c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115)

* 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829)

* ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102)

* 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181)

* d413081 Fix shrinkwrap on animated list (flutter/flutter#115104)

* bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118)

* 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122)

* 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124)

* c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128)

* 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132)

* 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123)

* f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134)

* 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135)

* 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139)

* c021d91 [flutter_tools] support github reporter (flutter/flutter#115137)

* 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142)

* 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)
stuartmorgan pushed a commit to flutter/packages that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll
Roll Flutter from b31b9dc05f99 to 098aac7ffeef (21 revisions) (#2802)
87d0404 
* 19b351b07 f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095)

* 5a600456b Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002)

* 09a4f2346 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075)

* 1f891a0f3 Fix `RangeSlider` semantics node size (flutter/flutter#114999)

* c1ceda41e Include stdout in codesign failure output (flutter/flutter#115115)

* 2e432ec16 chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829)

* ad72a452b 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102)

* 4e7dbefd9 Explicitly call out documentation links in "flutter create" (flutter/flutter#114181)

* d41308179 Fix shrinkwrap on animated list (flutter/flutter#115104)

* bd00a932c Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118)

* 8858c1764 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122)

* 0f2f4b860 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124)

* c6561e60a 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128)

* 6e89042d9 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132)

* 88e49ed27 Load assets in flutter_test without turning event loop. (flutter/flutter#115123)

* f9972818f Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134)

* 0d081f9c2 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135)

* 83cda7e52 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139)

* c021d9177 [flutter_tools] support github reporter (flutter/flutter#115137)

* 413bb21df e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142)

* 098aac7ff 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@gaaclarke @schwa423
Turned on performance-move-const-arg everywhere. (flutter#37482)
5da6b56 
Turned on performance-move-const-arg everywhere.
@jmagman jmagman mentioned this pull request Nov 17, 2022
Closed
8 tasks
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from b31b9dc05f99 to 098aac7ffeef (21 revisions) (flutte…
265555f 
…r#2802)

* 19b351b07 f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095)

* 5a600456b Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002)

* 09a4f2346 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075)

* 1f891a0f3 Fix `RangeSlider` semantics node size (flutter/flutter#114999)

* c1ceda41e Include stdout in codesign failure output (flutter/flutter#115115)

* 2e432ec16 chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829)

* ad72a452b 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102)

* 4e7dbefd9 Explicitly call out documentation links in "flutter create" (flutter/flutter#114181)

* d41308179 Fix shrinkwrap on animated list (flutter/flutter#115104)

* bd00a932c Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118)

* 8858c1764 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122)

* 0f2f4b860 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124)

* c6561e60a 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128)

* 6e89042d9 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132)

* 88e49ed27 Load assets in flutter_test without turning event loop. (flutter/flutter#115123)

* f9972818f Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134)

* 0d081f9c2 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135)

* 83cda7e52 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139)

* c021d9177 [flutter_tools] support github reporter (flutter/flutter#115137)

* 413bb21df e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142)

* 098aac7ff 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter#6692)
c41c67f 
* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088)

* ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042)

* b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093)

* 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095)

* 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002)

* 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075)

* 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999)

* c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115)

* 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829)

* ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102)

* 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181)

* d413081 Fix shrinkwrap on animated list (flutter/flutter#115104)

* bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118)

* 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122)

* 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124)

* c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128)

* 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132)

* 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123)

* f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134)

* 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135)

* 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139)

* c021d91 [flutter_tools] support github reporter (flutter/flutter#115137)

* 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142)

* 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
f467eee51 Turned on performance-move-const-arg everywhere. (flutter/e…
1325fd9 
…ngine#37482) (flutter#115095)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
f467eee51 Turned on performance-move-const-arg everywhere. (flutter/e…
b59eb09 
…ngine#37482) (flutter#115095)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter#6692)
5799b79 
* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088)

* ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042)

* b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093)

* 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095)

* 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002)

* 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075)

* 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999)

* c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115)

* 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829)

* ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102)

* 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181)

* d413081 Fix shrinkwrap on animated list (flutter/flutter#115104)

* bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118)

* 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122)

* 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124)

* c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128)

* 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132)

* 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123)

* f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134)

* 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135)

* 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139)

* c021d91 [flutter_tools] support github reporter (flutter/flutter#115137)

* 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142)

* 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
platform-ios will affect goldens
Projects
None yet
Milestone
No milestone
3 participants
@gaaclarke @skia-gold @zanderso