-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Set color attachment pixel format to RGBA on OpenGLES backend #37843
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…115891) * 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843) * f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
…lutter#115891) * 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843) * f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
…lutter#115891) * 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843) * f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
Now on the OpenGLES backend, the pixel format is set to BGRA, but actually ends up internally as
GL_RGBA
. This does not affect normal rendering logic.However, when the developers need to copy the Texture to the CPU Buffer through the Blit operation, the developers need to know the pixel format of the Texture, and the pixel format obtained via
TextureDescriptor.format
is BGRA, but in fact the correct pixel format is RGBA.This PR will set the color attachment pixel format of the OpenGLES backend to RGBA. I believe this PR works fine for both OpenGLES and Metal, but not sure if it's true for the Vulkan backend as well.
Pre-launch Checklist
///
).