-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional uri field to routeInformationUpdated to accept entir… #40250
Conversation
).toString(), | ||
); | ||
} else { | ||
path = arguments!.tryString('location')!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan is to deprecate location
and framework would only send using uri
. I am not sure what may be the best way to do this. Maybe I should create a new channel method, but that feels a bit overkill
Looks like some checks are failing. |
A friendly bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lib/web_ui/test/window_test.dart
Outdated
const JSONMethodCodec().encodeMethodCall(const MethodCall( | ||
'routeInformationUpdated', | ||
<String, dynamic>{ | ||
'uri': 'http://myhostname.com/baz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this uri a little more complete to make sure we are capturing query params and fragment?
6315ac4
to
505fd6c
Compare
…cept entir… (flutter/engine#40250) (#123430) Roll Flutter Engine from 78c7f9571c5a to 608d5b214faa (1 revision)
…ted to accept entir… (flutter/engine#40250) (#123430) Commit: d45c142f3db4d7af9f24c3f37a0b1e08e4267066
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
flutter#40250) Added additional uri field to routeInformationUpdated to accept entir�
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
…e uri
This unblocks flutter/flutter#119968
Related: flutter/flutter#100624
The goal is to make sure all the route path is passing through framework and engine in full uri format. This is useful if framework would like to handle deeplink from different domains in non-web platform.
While the feature is unrelated to web (at least there isn't a use case for web), but I migrate the routeInformationUpdated to make the API more unified.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.