Added additional uri field to routeInformationUpdated to accept entir… #40250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
chunhtai
commented
Mar 13, 2023
| ).toString(), | ||
| ); | ||
| } else { | ||
| path = arguments!.tryString('location')!; |
There was a problem hiding this comment.
The plan is to deprecate location and framework would only send using uri. I am not sure what may be the best way to do this. Maybe I should create a new channel method, but that feels a bit overkill
|
Looks like some checks are failing. |
|
A friendly bump |
mdebbar
approved these changes
Mar 24, 2023
lib/web_ui/test/window_test.dart
Outdated
| const JSONMethodCodec().encodeMethodCall(const MethodCall( | ||
| 'routeInformationUpdated', | ||
| <String, dynamic>{ | ||
| 'uri': 'http://myhostname.com/baz', |
There was a problem hiding this comment.
Maybe make this uri a little more complete to make sure we are capturing query params and fragment?
chunhtai
force-pushed
the
browser-update
branch
from
6315ac4
to
505fd6c
Compare
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2023
…cept entir… (flutter/engine#40250) (#123430) Roll Flutter Engine from 78c7f9571c5a to 608d5b214faa (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 24, 2023
…ted to accept entir… (flutter/engine#40250) (#123430) Commit: d45c142f3db4d7af9f24c3f37a0b1e08e4267066
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
eyebrowsoffire
pushed a commit
to eyebrowsoffire/engine
that referenced
this pull request
Mar 27, 2023
flutter#40250) Added additional uri field to routeInformationUpdated to accept entir�
8 tasks
This was referenced Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ated to accept entir… (flutter/engine#40250) (flutter/flutter#123430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e uri
This unblocks flutter/flutter#119968
Related: flutter/flutter#100624
The goal is to make sure all the route path is passing through framework and engine in full uri format. This is useful if framework would like to handle deeplink from different domains in non-web platform.
While the feature is unrelated to web (at least there isn't a use case for web), but I migrate the routeInformationUpdated to make the API more unified.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.