Revert "[Impeller] iOS/macOS: Only wait for command scheduling prior to present" #40895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Apr 3, 2023
bdero
approved these changes
Apr 3, 2023
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40895, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2023
…ing prior to present" (flutter/engine#40895)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2023
…ing prior to present" (flutter/engine#40895)
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 26, 2023
…g prior to present" (flutter#40895)" This reverts commit b580325.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 26, 2023
…nt (redux) Reverts flutter#40895.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 26, 2023
…nt (redux) Reverts flutter#40895.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 26, 2023
…nt (redux) Reverts flutter#40895.
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Apr 26, 2023
…nt (redux) Reverts flutter#40895.
bdero
added a commit
that referenced
this pull request
Apr 26, 2023
…nt (redux) (#41501) Reverts #40895. Resolves flutter/flutter#120399 (again). A bunch of frames get pumped on the main thread _without a transaction_ just before unmerging occurs (I don't know why this happens), and so checking the current thread to determine whether we need to present with a transaction or not isn't sufficient. In the prior fix, after the unmerge, the raster thread would hang for one second while waiting for the next drawable to get freed up (happens on the second raster thread frame post-unmerge), and then subsequent presents would just do nothing for a while, but eventually recover. `presentsWithTransaction` works whether the `CATransaction` stack is empty or not, and so the only difference here is that `presentsWithTransaction` is always turned on and `presentDrawable` is always avoided (otherwise it tries to present too early and nothing renders when platform views are present).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40781
Fixes flutter/flutter#124056
When unmerging threads we appear to get stuck for multiple seconds. Haven't debugged further, but bisected to this commit.