Switch linux_android_debug_engine from goma to reclient #45345
Conversation
keyonghan
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
@zanderso How shall I proceed to resolve these gold images? |
|
I am not seeing any diffs to triage. This looks like it could be a bug in SkiaGold. You might try rebasing the PR. |
|
Golden file changes are available for triage from new commit, Click here to view. |
Rebase helps. The PR is ready for review. The linux_android_debug_engine took 25 mins, which seems comparable with goma, considering roughly different number of cache hits. |
There was a problem hiding this comment.
LGTM but perhaps @zanderso should also take a look over it.
keyonghan
added
the
autosubmit
…134791) flutter/engine@45bc430...67dd12f 2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 2023-09-14 54558023+keyonghan@users.noreply.github.com Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to reclient fro standalone targets (flutter/engine#45804) 2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#134791) flutter/engine@45bc430...67dd12f 2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 2023-09-14 54558023+keyonghan@users.noreply.github.com Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to reclient fro standalone targets (flutter/engine#45804) 2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#132701.