Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch goma to reclient fro standalone targets #45804

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

keyonghan
Copy link
Contributor

@keyonghan
Copy link
Contributor Author

keyonghan commented Sep 14, 2023

First run of benchmark: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_benchmarks/1/overview, which took 57 mins without hitting any cache;
Second run of benchmark: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_benchmarks/2/overview, which took 10 mins.

The android_emulator_tests: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_tests/2/overview, which took 13 mins with cache hit.

@zanderso
Copy link
Member

In what situations will the build take 57 minutes?

@keyonghan
Copy link
Contributor Author

In what situations will the build take 57 minutes?

Where we do not have a single cache hit:

num_records: 5510
stats: {
	name: "CompletionStatus"
	counts_by_value: {
		name: "STATUS_LOCAL_FALLBACK"
		count: 43
	}
	counts_by_value: {
		name: "STATUS_REMOTE_EXECUTION"
		count: 5467
	}
}

@zanderso
Copy link
Member

My question is in what situations can we expect to not have a single cache hit. Is this something that will happen on every commit? Once a day? Once a week?

@keyonghan
Copy link
Contributor Author

My question is in what situations can we expect to not have a single cache hit. Is this something that will happen on every commit? Once a day? Once a week?

I expect this happens only the first time of the build, where the cache is empty (Run your builds and tests using the remote cache).

@zanderso
Copy link
Member

I expect this happens only the first time of the build, where the cache is empty (Run your builds and tests using the remote cache).

What does "the first time of the build" mean? The first time on any given commit? Or the first time with the repo?

I'm also confused by the documentation at that link. It says, "the cache is empty, so all actions are executed locally". That is very different from goma, which I believe uses the remote workers to run the compile commands even when there isn't a cache hit?

@keyonghan
Copy link
Contributor Author

I expect this happens only the first time of the build, where the cache is empty (Run your builds and tests using the remote cache).

What does "the first time of the build" mean? The first time on any given commit? Or the first time with the repo?

I'm also confused by the documentation at that link. It says, "the cache is empty, so all actions are executed locally". That is very different from goma, which I believe uses the remote workers to run the compile commands even when there isn't a cache hit?

The first execution time with the task/builder, which should be the same with the repo.

I should have pointed out that the link focuses on using remote cache for local runs (the topic right after is Setting up remote execution) . Since we have set up remote execution, if no cache hit, it will try remote execution first. This is aligned with the stats: #45804 (comment)

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. That all sounds hunky-dory to me, then.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@keyonghan
Copy link
Contributor Author

I will monitor the coming builds to make sure things go well as expected. Landing now.

@auto-submit auto-submit bot merged commit 5512613 into flutter:main Sep 14, 2023
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2023
…134791)

flutter/engine@45bc430...67dd12f

2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
…lutter#134791)

flutter/engine@45bc430...67dd12f

2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants