Add more missing Skia #includes #46034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianosman
approved these changes
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 19, 2023
…sions) (#135041) Manual roll requested by jonahwilliams@google.com flutter/engine@589bde9...28f14e6 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (flutter/engine#46048) 2023-09-19 jacksongardner@google.com Update CI to Chrome 117 (flutter/engine#45842) 2023-09-19 mdebbar@google.com [web] DOM objects implement JS object (flutter/engine#46047) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 91adc7d289f7 to d54cf63f051b (3 revisions) (flutter/engine#46043) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040) 2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039) 2023-09-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038) 2023-09-19 kjlubick@users.noreply.github.com Add more missing Skia #includes (flutter/engine#46034) 2023-09-19 leroux_bruno@yahoo.fr [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848) 2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…sions) (flutter#135041) Manual roll requested by jonahwilliams@google.com flutter/engine@589bde9...28f14e6 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (flutter/engine#46048) 2023-09-19 jacksongardner@google.com Update CI to Chrome 117 (flutter/engine#45842) 2023-09-19 mdebbar@google.com [web] DOM objects implement JS object (flutter/engine#46047) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 91adc7d289f7 to d54cf63f051b (3 revisions) (flutter/engine#46043) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040) 2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039) 2023-09-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038) 2023-09-19 kjlubick@users.noreply.github.com Add more missing Skia #includes (flutter/engine#46034) 2023-09-19 leroux_bruno@yahoo.fr [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848) 2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028) 2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Ran into compile errors when refactoring Skia's #includes. This addresses those ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into compile errors when refactoring Skia's #includes. This addresses those
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.