Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] DOM objects implement JS object #46047

Merged
merged 1 commit into from Sep 19, 2023
Merged

[web] DOM objects implement JS object #46047

merged 1 commit into from Sep 19, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Sep 19, 2023

Instead of doing as JSAny for DOM objects that are defined in static JS interop, let's make them implements JSObject?

cc @eyebrowsoffire @srujzs thoughts?

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Sep 19, 2023
eyebrowsoffire
eyebrowsoffire reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you for doing this!

srujzs
srujzs approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! At some point we may migrate all JS types to extension types for readability, but that'll be further down the road and we'll probably migrate this entire file to extension types before then.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2023
@auto-submit auto-submit bot merged commit 58f6fe2 into flutter:main Sep 19, 2023
25 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
58f6fe23b [web] DOM objects implement JS object (flutter/engine#46047)
78ac6a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
58f6fe23b [web] DOM objects implement JS object (flutter/engine#46047)
ebc10da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
58f6fe23b [web] DOM objects implement JS object (flutter/engine#46047)
be4e476
jonahwilliams pushed a commit to flutter/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from 589bde9a95c9 to 28f14e6eec4f (11 revi…
5b47fef 
…sions) (#135041)

Manual roll requested by jonahwilliams@google.com

flutter/engine@589bde9...28f14e6

2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from d54cf63f051b to
d756a2f5665d (5 revisions) (flutter/engine#46048)
2023-09-19 jacksongardner@google.com Update CI to Chrome 117
(flutter/engine#45842)
2023-09-19 mdebbar@google.com [web] DOM objects implement JS object
(flutter/engine#46047)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 91adc7d289f7 to
d54cf63f051b (3 revisions) (flutter/engine#46043)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 1e84aa4509cd to
91adc7d289f7 (2 revisions) (flutter/engine#46040)
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039)
2023-09-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038)
2023-09-19 kjlubick@users.noreply.github.com Add more missing Skia
#includes (flutter/engine#46034)
2023-09-19 leroux_bruno@yahoo.fr [macOS,iOS] Expose channel buffers
'resize' and 'overflow' control co… (flutter/engine#44848)
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 744807d740c7 to
1e84aa4509cd (4 revisions) (flutter/engine#46026)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
58f6fe23b [web] DOM objects implement JS object (flutter/engine#46047)
c960fd8
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Manual roll Flutter Engine from 589bde9a95c9 to 28f14e6eec4f (11 revi…
fbd1138 
…sions) (flutter#135041)

Manual roll requested by jonahwilliams@google.com

flutter/engine@589bde9...28f14e6

2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from d54cf63f051b to
d756a2f5665d (5 revisions) (flutter/engine#46048)
2023-09-19 jacksongardner@google.com Update CI to Chrome 117
(flutter/engine#45842)
2023-09-19 mdebbar@google.com [web] DOM objects implement JS object
(flutter/engine#46047)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 91adc7d289f7 to
d54cf63f051b (3 revisions) (flutter/engine#46043)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 1e84aa4509cd to
91adc7d289f7 (2 revisions) (flutter/engine#46040)
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039)
2023-09-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038)
2023-09-19 kjlubick@users.noreply.github.com Add more missing Skia
#includes (flutter/engine#46034)
2023-09-19 leroux_bruno@yahoo.fr [macOS,iOS] Expose channel buffers
'resize' and 'overflow' control co… (flutter/engine#44848)
2023-09-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028)
2023-09-19 skia-flutter-autoroll@skia.org Roll Skia from 744807d740c7 to
1e84aa4509cd (4 revisions) (flutter/engine#46026)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O-

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the dom_implements_js_object branch October 20, 2023 20:27
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@mdebbar @harryterkelsen
[web] DOM objects implement JS object (#46047)
c0dd419 
Instead of doing `as JSAny` for DOM objects that are defined in static JS interop, let's make them `implements JSObject`?

cc @eyebrowsoffire @srujzs thoughts?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire left review comments

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
3 participants
@mdebbar @eyebrowsoffire @srujzs