Remove support for Paint.enableDithering=false in dart:ui.
#46745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _dither = true; | ||
| } | ||
| // TODO(matanlurey): Remove as part of https://github.com/flutter/flutter/issues/112498. | ||
| _enableDithering(); |
There was a problem hiding this comment.
Do we need to leave this in for now? Could we just rip it out entirely?
There was a problem hiding this comment.
We could rip it out with a much larger change, but I'm trying to do it piecemeal (i.e. #46746).
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/46745, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/46745, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2023
…136307) flutter/engine@ea275c3...8086814 2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745) 2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748) 2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Work towards flutter/flutter#112498. No behavioral changes to existing code, except `Paint.enableDithering = false` will no longer be an option.
matanlurey
added a commit
that referenced
this pull request
Oct 24, 2023
Partial work towards flutter/flutter#112498. Won't land this until #46745 is merged, so expect some redness until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#112498.
No behavioral changes to existing code, except
Paint.enableDithering = falsewill no longer be an option.