[Impeller] Adjust advanced blend construction to avoid moto g4 crash. #47637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I wonder why the test bot isn't complaining. Maybe it doesn't know about |
zanderso
previously approved these changes
Nov 3, 2023
|
This shouldn't trigger malioc because the shader should be identical after some inlining/constant folding. Yeah, we can ask about the bot |
zanderso
dismissed
their stale review
The original patch slipped into the 3.17 beta. We should revert it first so it can be CP'd
|
I'll just merge this into the reland. |
bdero
reviewed
Nov 6, 2023
| @@ -22,39 +22,51 @@ | |||
| // kColor, | |||
| // kLuminosity, | |||
| // Note, this isn't a switch as GLSL ES 1.0 does not support them. | |||
| #define AdvancedBlend(blend_type) \ | |||
There was a problem hiding this comment.
Ah, yeah this shader was totally broken for all backends (impellerc runs the preprocessor), but we just don't use this shader on iOS anymore. GL goldens on CI would have caught this.
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
Reland of #47432 Also includes: * #47617 * #47637 Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation. ---- Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs. Fixes flutter/flutter#136210 Fixes flutter/flutter#119357
auto-submit bot
added a commit
that referenced
this pull request
Nov 7, 2023
…47762) Reverts #47678 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Reland of #47432 Also includes: * #47617 * #47637 Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation. ---- Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs. Fixes flutter/flutter#136210 Fixes flutter/flutter#119357
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Reland of #47432 Also includes: #47617 #47637 Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation. Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs. Fixes flutter/flutter#136210 Fixes flutter/flutter#119357 Investigating: flutter/flutter#138028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arrange how the advanced blend shaders are constructed to simplify the shader slightly, avoid moto g4 driver crash.
Fixes flutter/flutter#137816
This is tested, but the test is in the framework repo for reasons.