[Impeller] Add support for specialization constants redux. #47678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/engine into add_specialization_support
jonahwilliams
commented
Nov 4, 2023
| @@ -59,7 +52,31 @@ | |||
| descriptor.stencilAttachmentPixelFormat = | |||
| ToMTLPixelFormat(desc.GetStencilPixelFormat()); | |||
|
|
|||
| return descriptor; | |||
| const auto& constants = desc.GetSpecializationConstants(); | |||
There was a problem hiding this comment.
This is still a bit iffy, but we improve performance by not blocking on the specialization, it all goes into the same pipeline future which is only blocking once we actually trry to use it.
Since the compilation is out of process anyway, blocking on it is pointless and only serves to park the thread.
There was a problem hiding this comment.
Feels like we're writing javascript here with this chain of nested completion callbacks. ;) Looks safe to me, though.
jonahwilliams
commented
Nov 4, 2023
| @@ -133,19 +150,12 @@ | |||
| )); | |||
| promise->set_value(new_pipeline); | |||
| }; | |||
| auto mtl_descriptor = GetMTLRenderPipelineDescriptor(descriptor); | |||
| #if FML_OS_IOS | |||
There was a problem hiding this comment.
Actually, i see this issue is closed. Is this intended to be removed now?
jonahwilliams
changed the title
bdero
approved these changes
Nov 6, 2023
| @@ -59,7 +52,31 @@ | |||
| descriptor.stencilAttachmentPixelFormat = | |||
| ToMTLPixelFormat(desc.GetStencilPixelFormat()); | |||
|
|
|||
| return descriptor; | |||
| const auto& constants = desc.GetSpecializationConstants(); | |||
There was a problem hiding this comment.
Feels like we're writing javascript here with this chain of nested completion callbacks. ;) Looks safe to me, though.
| return descriptor; | ||
| // This latch is used to ensure that GetMTLFunctionSpecialized does not finish | ||
| // before the descriptor is completely set up. | ||
| auto latch = std::make_shared<fml::CountDownLatch>(1u); |
There was a problem hiding this comment.
Nothing appears to be waiting on this latch, and I'm not sure why we'd need one. It looks like the descriptor is already done being set up by the time we call GetMTLFunctionSpecialized.
There was a problem hiding this comment.
Removed. This was left over from an earlier iteration.
jonahwilliams
added
the
autosubmit
jonahwilliams
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Nov 7, 2023
…47762) Reverts #47678 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Reland of #47432 Also includes: * #47617 * #47637 Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation. ---- Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs. Fixes flutter/flutter#136210 Fixes flutter/flutter#119357
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 7, 2023
…138034) flutter/engine@1b20752...f8961d2 2023-11-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Add support for specialization constants redux." (flutter/engine#47762) 2023-11-07 30870216+gaaclarke@users.noreply.github.com [Impeller] added tests for matrices (flutter/engine#47754) 2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 62fc1374cc5d to 030e21befbc9 (2 revisions) (flutter/engine#47756) 2023-11-07 ychris@google.com [ios] making objective-C smart pointers support ARC (flutter/engine#47612) 2023-11-07 zanderso@users.noreply.github.com Don't use Skia BUILD.gn files (flutter/engine#47677) 2023-11-07 jonahwilliams@google.com [Impeller] Add support for specialization constants redux. (flutter/engine#47678) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #47432
Also includes:
Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.
Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.
Fixes flutter/flutter#136210
Fixes flutter/flutter#119357