Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Disable compute for Vulkan. #49463

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

jonahwilliams
Copy link
Member

This code is missing correct barriers which cannot be specified at the HAL level, see flutter/flutter#140798

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot merged commit c62bcff into flutter:main Jan 3, 2024
27 checks passed
@jonahwilliams jonahwilliams deleted the disable_compute_vulkan branch January 3, 2024 18:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 3, 2024
…140905)

flutter/engine@98b72c7...c62bcff

2024-01-03 jonahwilliams@google.com [Impeller] Disable compute for Vulkan. (flutter/engine#49463)
2024-01-03 dkwingsmt@users.noreply.github.com Revert skiping illegal render in Dart (flutter/engine#49473)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants