[Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. #49838
Conversation
|
Okay, this took me a bit longer to work out than I anticipated, but I think this is good to go now! The main problems were:
|
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
This is definitely not good to go, from the look of those goldens. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
bdero
force-pushed
the
bdero/depth2
branch
2 times, most recently
from
aebeb34
to
9a2f762
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
|
This is working now, problems were silly. I'm intentionally adding the depth attachment alongside the stencil as a baby step to make sure there's no extreme perf regression and/or validation problems. But I was setting the compare op to not always pass -- causing clearing passes to sometimes z-fight and non-clearing passes to compare against garbage depth. |
|
Took me a surprisingly long time to realize what was wrong since I was never managed to reproduce the bad behavior via local goldens or Wondrous on iOS. |
…pth+stencil buffer. (flutter/engine#49838)
…141978) flutter/engine@d653559...b2762f4 2024-01-22 32242716+ricardoamador@users.noreply.github.com Add Mac cache_builder back into Prod (flutter/engine#49936) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from cc042f38288e to be066a6524ab (2 revisions) (flutter/engine#49937) 2024-01-22 bdero@google.com [Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#49838) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#138460.
In preparation for draw order optimization and StC.
Use a transient depth+stencil texture instead of a stencil-only texture. Doing this in isolation to detect/weed out any bugs with handling the attachment.