Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix flutter in flutter_vma.h import #51065

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Prefix flutter in flutter_vma.h import #51065

merged 2 commits into from
Feb 28, 2024

Conversation

CaseyHillers
Copy link
Contributor

Breaks the Google build (b/327309677)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Prefix flutter in flutter_vma.h import
91fcb1b 
Breaks the Google build (b/327309677)
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams
jonahwilliams approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Feb 28, 2024

auto label is removed for flutter/engine/51065, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024
@auto-submit auto-submit bot merged commit b1e9854 into main Feb 28, 2024
26 checks passed
@auto-submit auto-submit bot deleted the CaseyHillers-patch-4 branch February 28, 2024 22:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 29, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 29, 2024
@engine-flutter-autoroll
b1e9854b5 Prefix flutter in flutter_vma.h import (flutter/engine#51065)
ad52d75
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 29, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (#…
52d45c4 
…144355)

flutter/engine@10331db...61510db

2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068)
2024-02-28 chillers@google.com Prefix flutter in flutter_vma.h import (flutter/engine#51065)
2024-02-28 jonahwilliams@google.com [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990)
2024-02-28 matanlurey@users.noreply.github.com Test the `SurfaceTextureSurfaceProducer`-branch in the Android `scenario_app` (flutter/engine#51061)
2024-02-28 jacksongardner@google.com Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@chingjun chingjun Awaiting requested review from chingjun

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Milestone
No milestone
2 participants
@CaseyHillers @jonahwilliams