New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Abseil from src to flutter third_party dir #51245
Conversation
In combination with: * https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848 * flutter/buildroot#831 this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This will fail presubmit due to the licence script; once that fails I'll check the results, patch and re-push. |
test-exempt: just moving source paths |
auto label is removed for flutter/engine/51245, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…144746) flutter/engine@8a859c5...03ebd64 2024-03-07 jonahwilliams@google.com [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246) 2024-03-07 chris@bracken.jp Move Abseil from src to flutter third_party dir (flutter/engine#51245) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
In combination with:
this updates Flutter's references to Abseil from
//third_party/abseil-cpp to //flutter/third_party/abseil-cpp.
Issue: flutter/flutter#144201
Part of: flutter/flutter#67373
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.