Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] add a per-frame trace event for heap usage on Vulkan. #51246

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 7, 2024

Part of flutter/flutter#144617

Adds MemoryBudgetUsageMB which includes the MB of VMA allocated GPU and host memory, approximately per frame. This will be recorded in the devicelab and used to track how much memory pressure we're creating.

Split out from #51187 since that was reverted (and doing big changes is a bad idea anyway).

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promised PR

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2024
@auto-submit auto-submit bot merged commit 03ebd64 into flutter:main Mar 7, 2024
28 checks passed
@jonahwilliams jonahwilliams deleted the just_log_mb_numbers branch March 7, 2024 01:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2024
…144746)

flutter/engine@8a859c5...03ebd64

2024-03-07 jonahwilliams@google.com [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246)
2024-03-07 chris@bracken.jp Move Abseil from src to flutter third_party dir (flutter/engine#51245)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
2 participants