Make scenario app have translucent splash screen so it doesn't affect screenshot colors #51329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Mar 11, 2024
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
gmackall
added
the
autosubmit
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2024
…n't affect screenshot colors (flutter/engine#51329)
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Skips animations Looks like this, for reference: [no_animation_example.webm](https://github.com/flutter/engine/assets/34871572/0c8665a3-b546-4bbd-b7e1-00851c48e1ff) (This is the animation from #51329, so note that the first test looks weird because I lagged my emulator by alt tabbing). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2024
…ions) (#145002) Manual roll requested by zra@google.com flutter/engine@6cefbe1...6771307 2024-03-11 ditman@gmail.com [web] Split initialization of the _flutter namespace and loader object. (flutter/engine#51294) 2024-03-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 09a1a1ede1c4 to 7a2c94fd0a26 (1 revision) (flutter/engine#51338) 2024-03-11 skia-flutter-autoroll@skia.org Roll Skia from 6f10903e2d28 to 32f1cb50734a (5 revisions) (flutter/engine#51331) 2024-03-11 34871572+gmackall@users.noreply.github.com Make scenario app have translucent splash screen so it doesn't affect screenshot colors (flutter/engine#51329) 2024-03-11 zanderso@users.noreply.github.com [gn] Change sdk_rewriter() template to use depfiles (flutter/engine#51314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the scenario app splash screen have a translucent color, so it doesn't end up overlaying on screenshots.
Before:
device-2024-03-07-152047.webm
After:
translucentsplash.webm
This sort of fixes flutter/flutter#144657? The issue is still odd to me, though, because I don't know why the test runner wouldn't be waiting properly for the splash screen.
Bonus, this is what it looks like if we change the runner to not use animations, with
--no-window-animation(but don't include the splash screen change):no_animation_example.webm
You can see there is still a moment of color change at the end of tests (ignore the very first test I was alt tabbing and lagged out my emulator).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.