Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated analysis exclusion #52699

Merged
merged 1 commit into from
May 9, 2024
Merged

updated analysis exclusion #52699

merged 1 commit into from
May 9, 2024

Conversation

gaaclarke
Copy link
Member

related issue Dart-Code/Dart-Code#5101

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from matanlurey May 9, 2024 16:46
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@gaaclarke gaaclarke merged commit 233a57b into flutter:main May 9, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
zanderso pushed a commit to flutter/flutter that referenced this pull request May 10, 2024
…148137)

flutter/engine@c0917b1...1ccd0c3

2024-05-10 30870216+gaaclarke@users.noreply.github.com Fixed constness
of display list storage. (flutter/engine#52705)
2024-05-10 zanderso@users.noreply.github.com Revert "Various
documentation improvements (#52600)" (flutter/engine#52709)
2024-05-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b7cad2edae4b to 01121c008f4d (3 revisions) (flutter/engine#52706)
2024-05-10 gray@tacck.net [iOS] Fix App crash when use WebView with iOS
VoiceOver (flutter/engine#52484)
2024-05-09 ian@hixie.ch Various documentation improvements (#52600)
(flutter/engine#52623)
2024-05-09 yjbanov@google.com [web] scale semantic text elements to
match the desired focus ring size (flutter/engine#52586)
2024-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds
impeller display list golden tests (flutter/engine#52690)
2024-05-09 zanderso@users.noreply.github.com Roll buildroot to
70a42312a688 (flutter/engine#52675)
2024-05-09 matanlurey@users.noreply.github.com When `et` is not attached
to a terminal, still split lines for status updates.
(flutter/engine#52681)
2024-05-09 30870216+gaaclarke@users.noreply.github.com updated analysis
exclusion (flutter/engine#52699)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants