Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Adds impeller display list golden tests #52690

Merged
merged 10 commits into from
May 9, 2024
Merged

[Impeller] Adds impeller display list golden tests #52690

merged 10 commits into from
May 9, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented May 8, 2024 •
edited

issue flutter/flutter#146941

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke
gaaclarke commented May 9, 2024
View reviewed changes
impeller/display_list/dl_golden_unittests.cc
INSTANTIATE_PLAYGROUND_SUITE(DlGoldenTest);

TEST_P(DlGoldenTest, CanDrawPaint) {
auto draw = [](DlCanvas* canvas,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered making an OpenPlaygroundHere that takes in this lambda, but decided to stick with the existing API. The lambda API would remove boilerplate, but this makes the golden tests more accessible to old tests if we want.

@gaaclarke gaaclarke marked this pull request as ready for review May 9, 2024 18:13
@gaaclarke gaaclarke changed the title [Impeller] Adds display list golden test [Impeller] Adds display list golden tests May 9, 2024
@gaaclarke gaaclarke changed the title [Impeller] Adds display list golden tests [Impeller] Adds impeller display list golden tests May 9, 2024
jonahwilliams
jonahwilliams reviewed May 9, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that the goldens are registered with the Aiks prefix, so when we migrate tests the existing goldens stay valid?

@gaaclarke
Copy link
Member Author

Can we make sure that the goldens are registered with the Aiks prefix, so when we migrate tests the existing goldens stay valid?

If we follow out the plan in flutter/flutter#146941 that's not going to be an issue since when the tests are migrated they will be in the exact same location and the names come from the location. They'll just be routed through the display lists instead.

@jonahwilliams
Copy link
Member

I'd like to lift and sift the existing tests without any shims that need to be maintained

@gaaclarke
Copy link
Member Author

I'd like to lift and sift the existing tests without any shims that need to be maintained

However we do it we can keep the old names. If one wanted to manually migrate a test they'd just put it in a test suite that uses the AiksTest name. That's already been setup in things like aiks_blend_unittests.cc. This PR won't stop us from doing that migration however we want. This PR just adds the ability to write tests against display lists and these 2 tests are just a stake in the ground to make sure we can continue to do that. They also provides some coverage for display list / impeller integration as well. I'll leave migration for another day.

jonahwilliams
jonahwilliams approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #52690 at sha 32b911c

@gaaclarke gaaclarke merged commit c674206 into flutter:main May 9, 2024
34 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
@engine-flutter-autoroll
c67420620 [Impeller] Adds impeller display list golden tests (flutter…
f6893ec 
…/engine#52690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2024
@engine-flutter-autoroll
c67420620 [Impeller] Adds impeller display list golden tests (flutter…
4825201 
…/engine#52690)
zanderso pushed a commit to flutter/flutter that referenced this pull request May 10, 2024
@engine-flutter-autoroll
Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (#…
9c881ce 
…148137)

flutter/engine@c0917b1...1ccd0c3

2024-05-10 30870216+gaaclarke@users.noreply.github.com Fixed constness
of display list storage. (flutter/engine#52705)
2024-05-10 zanderso@users.noreply.github.com Revert "Various
documentation improvements (#52600)" (flutter/engine#52709)
2024-05-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b7cad2edae4b to 01121c008f4d (3 revisions) (flutter/engine#52706)
2024-05-10 gray@tacck.net [iOS] Fix App crash when use WebView with iOS
VoiceOver (flutter/engine#52484)
2024-05-09 ian@hixie.ch Various documentation improvements (#52600)
(flutter/engine#52623)
2024-05-09 yjbanov@google.com [web] scale semantic text elements to
match the desired focus ring size (flutter/engine#52586)
2024-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds
impeller display list golden tests (flutter/engine#52690)
2024-05-09 zanderso@users.noreply.github.com Roll buildroot to
70a42312a688 (flutter/engine#52675)
2024-05-09 matanlurey@users.noreply.github.com When `et` is not attached
to a terminal, still split lines for status updates.
(flutter/engine#52681)
2024-05-09 30870216+gaaclarke@users.noreply.github.com updated analysis
exclusion (flutter/engine#52699)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jonahwilliams jonahwilliams mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@flar flar Awaiting requested review from flar

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens
Projects
None yet
Milestone
No milestone
2 participants
@gaaclarke @jonahwilliams