When et is not attached to a terminal, still split lines for status updates.
#52681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
johnmccutchan
approved these changes
May 8, 2024
zanderso
approved these changes
May 8, 2024
| @@ -169,6 +169,8 @@ class Logger { | |||
| /// and emits a carriage return. | |||
| void clearLine() { | |||
| if (!io.stdout.hasTerminal || _test) { | |||
| // Just write a newline if we're not in a terminal. | |||
| _ioSinkWrite(io.stdout, '\n'); | |||
There was a problem hiding this comment.
Please update the doc comment for the behavior change.
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2024
…for status updates. (flutter/engine#52681)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2024
…for status updates. (flutter/engine#52681)
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2024
…148137) flutter/engine@c0917b1...1ccd0c3 2024-05-10 30870216+gaaclarke@users.noreply.github.com Fixed constness of display list storage. (flutter/engine#52705) 2024-05-10 zanderso@users.noreply.github.com Revert "Various documentation improvements (#52600)" (flutter/engine#52709) 2024-05-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from b7cad2edae4b to 01121c008f4d (3 revisions) (flutter/engine#52706) 2024-05-10 gray@tacck.net [iOS] Fix App crash when use WebView with iOS VoiceOver (flutter/engine#52484) 2024-05-09 ian@hixie.ch Various documentation improvements (#52600) (flutter/engine#52623) 2024-05-09 yjbanov@google.com [web] scale semantic text elements to match the desired focus ring size (flutter/engine#52586) 2024-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds impeller display list golden tests (flutter/engine#52690) 2024-05-09 zanderso@users.noreply.github.com Roll buildroot to 70a42312a688 (flutter/engine#52675) 2024-05-09 matanlurey@users.noreply.github.com When `et` is not attached to a terminal, still split lines for status updates. (flutter/engine#52681) 2024-05-09 30870216+gaaclarke@users.noreply.github.com updated analysis exclusion (flutter/engine#52699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For illustrative purposes:
... should still get line-per-line status updates, but it does not without this patch.
It's hard to write tests because of global state, so I've declined to do so at the moment.
Closes flutter/flutter#147903.