[Impeller] Fix stroke curves. #52978
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This should cause some of the tests to fail. Going to update them once they do. : ) |
bdero
force-pushed
the
bdero/fix-stroke-curves
branch
from
1965f9b
to
bca2a4b
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Does this also resolve flutter/flutter#148323? |
|
I eyeballed the pending goldens and they look right to me. woot. |
|
Well this is way better captured by the goldens than I was anticipating. |
…148950) flutter/engine@964f087...2a48302 2024-05-23 bdero@google.com [Impeller] Fix stroke curves. (flutter/engine#52978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
We should discuss cherry picking this. I've added a prompt to the weekly. |
…lutter#148950) flutter/engine@964f087...2a48302 2024-05-23 bdero@google.com [Impeller] Fix stroke curves. (flutter/engine#52978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Resolves flutter/flutter#147139. Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour. Before: <img width="640" alt="Screenshot 2024-05-21 at 11 18 51�PM" src="https://github.com/flutter/engine/assets/919017/22d9fee7-834f-4cb4-8ed4-578a7c17f7a2"> <img width="121" alt="Screenshot 2024-05-21 at 11 19 35�PM" src="https://github.com/flutter/engine/assets/919017/419029b1-9a5f-4a30-bbb0-83dafc79f7df"> After: <img width="640" alt="Screenshot 2024-05-21 at 11 17 25�PM" src="https://github.com/flutter/engine/assets/919017/629e30a5-d0c5-4b7a-a3e2-bf715aa4ba78"> <img width="115" alt="Screenshot 2024-05-21 at 11 16 38�PM" src="https://github.com/flutter/engine/assets/919017/12e51892-6009-47d0-a4e5-1f1b017c99e8">
Resolves flutter/flutter#147139. Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour. Before: <img width="640" alt="Screenshot 2024-05-21 at 11 18 51�PM" src="https://github.com/flutter/engine/assets/919017/22d9fee7-834f-4cb4-8ed4-578a7c17f7a2"> <img width="121" alt="Screenshot 2024-05-21 at 11 19 35�PM" src="https://github.com/flutter/engine/assets/919017/419029b1-9a5f-4a30-bbb0-83dafc79f7df"> After: <img width="640" alt="Screenshot 2024-05-21 at 11 17 25�PM" src="https://github.com/flutter/engine/assets/919017/629e30a5-d0c5-4b7a-a3e2-bf715aa4ba78"> <img width="115" alt="Screenshot 2024-05-21 at 11 16 38�PM" src="https://github.com/flutter/engine/assets/919017/12e51892-6009-47d0-a4e5-1f1b017c99e8">
Resolves flutter/flutter#147139.
Added an explanation inline for why we need to use different direction values depending on whether or not we're capping off the last component of the contour.
Before:
After:
