Add missing top level to stub_ui #9060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/stub_ui/lib/src/ui/text.dart
Outdated
| // If we actually run on big endian machines, we'll need to do something smarter | ||
| // here. We don't use [Endian.Host] because it's not a compile-time | ||
| // constant and can't propagate into the set/get calls. | ||
| const Endian _kFakeHostEndian = Endian.little; |
There was a problem hiding this comment.
This constant was moved to lib/ui/natives.dart.
Does stub_ui have an equivalent of that file? Or should the code in text.dart that uses _kFakeHostEndian be removed from stub_ui?
There was a problem hiding this comment.
Moved it to natives - we can leave the implementation for now, just needs to compile
jason-simmons
approved these changes
May 22, 2019
|
Landing so we can unblock the framework rolls |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 22, 2019
flutter/engine@64f18f2...8dc3a4c git log 64f18f2..8dc3a4c --no-merges --oneline 8dc3a4c Add missing top level to stub_ui (flutter/engine#9060) 6299af3 remove over-optimistic assert (flutter/engine#9045) 0308a1c Roll src/third_party/dart fde6a5917e..e3edfd36b2 (14 commits) 1bce779 Roll src/third_party/skia e63b01b364a0..f77dbd04b926 (19 commits) (flutter/engine#9057) 4dbb9ba Expose pointer type and buttons in embedder.h (flutter/engine#9034) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.