Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) #9826

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jul 15, 2019

This is an automated pull request which will automatically merge once checks pass.

Roll src/third_party/dart 24725a8..cbaf890 (33 commits)

dart-lang/sdk@cbaf890f88 [kernel] Few more tweaks to ast_to_text for Constant nodes.
dart-lang/sdk@28f95fcd24 [cfe] Track dependencies in the incremental compiler
dart-lang/sdk@afac6b1d50 [kernel] Fix text serialization for Constant nodes
dart-lang/sdk@b64ab73b02 [cfe] Shard front-end tests
dart-lang/sdk@4686393ccb [cfe] Add test for the id testing system.
dart-lang/sdk@e4689c9302 [dart2js] Use new pragma directive syntax.
dart-lang/sdk@07a53a3cc9 Set onDiagnostic in DDCs incremental compiler code path
dart-lang/sdk@464a5a640f Issue 37401. Support for const Set default values in mocks.
dart-lang/sdk@55b67e9eae [vm/bytecode] Ignore source positions not denoting a debug point in debugger.
dart-lang/sdk@96906936b4 [vm/bytecode] Fix writing and reading of nested function types in bytecode
dart-lang/sdk@55078c0d2f [dartdevc] Fix emitting double constants from the SDK
dart-lang/sdk@1e4b799a58 It is an error for an extension to declare an abstract method
dart-lang/sdk@28962e1e80 Support static fields in extensions
dart-lang/sdk@7cadd70696 Fix language_2/ct_const_test
dart-lang/sdk@a917043332 APIs for editing Flutter widget properties.
dart-lang/sdk@09b93b7ea0 [fasta] Tweak fasta unit tests setup in anticipation of constant update 2018
dart-lang/sdk@3c3dc09d47 Test that ! on void is a compile time error
dart-lang/sdk@7139a2ab3a [vm] Fix function resolution so that it stops when it finds target even if it can't add method extractor.
dart-lang/sdk@d1bd3a2f43 [gardening] Fix language_2/generic_instanceof2_test
dart-lang/sdk@3dcaea5a25 [vm/aot/tfa] Update TFA unit tests to work with constants-update-2018
dart-lang/sdk@e95b1f7bf0 Make UNNECESSARY_NULL_AWARE_CALL a warning
dart-lang/sdk@2c26ece3cf [gardening] Fix non-web-integer in corelib_2/num_parse_test
dart-lang/sdk@1eb1520702 [vm/bytecode] Prevent triggering optimizing compilation from interpreter
dart-lang/sdk@ed764e5688 [gardening] Delete legacy parser_quirks_test
dart-lang/sdk@723bb0eee1 [dartdevc] make nullable_inference_test resilient to const refactor
dart-lang/sdk@f521f38b57 [vm/kernel] Handle InvalidExpression in constant contexts
dart-lang/sdk@0c9abb8816 [vm/ffi] Support structs on 32bit architectures
dart-lang/sdk@25bac04503 [tests] Delete temporary const tests
dart-lang/sdk@f40aac1b75 [cfe] Move general testcases into general/ subfolder
dart-lang/sdk@14ea27e65b [vm/concurrency] Make thread_registry not depend on [Isolate], move mutator thread from thread registry to isolate
dart-lang/sdk@97587b554f Update the element model to support extension methods
dart-lang/sdk@a8331cd109 Remove the STRONG_MODE_ prefix from error codes
dart-lang/sdk@4c5028d139 [vm/concurrency] Make an IsolateGroup object which will contain group-specific resources

dart-lang/sdk@cbaf890f88 [kernel] Few more tweaks to ast_to_text for Constant nodes.
dart-lang/sdk@28f95fcd24 [cfe] Track dependencies in the incremental compiler
dart-lang/sdk@afac6b1d50 [kernel] Fix text serialization for Constant nodes
dart-lang/sdk@b64ab73b02 [cfe] Shard front-end tests
dart-lang/sdk@4686393ccb [cfe] Add test for the id testing system.
dart-lang/sdk@e4689c9302 [dart2js] Use new pragma directive syntax.
dart-lang/sdk@07a53a3cc9 Set onDiagnostic in DDCs incremental compiler code path
dart-lang/sdk@464a5a640f Issue 37401. Support for const Set default values in mocks.
dart-lang/sdk@55b67e9eae [vm/bytecode] Ignore source positions not denoting a debug point in debugger.
dart-lang/sdk@96906936b4 [vm/bytecode] Fix writing and reading of nested function types in bytecode
dart-lang/sdk@55078c0d2f [dartdevc] Fix emitting double constants from the SDK
dart-lang/sdk@1e4b799a58 It is an error for an extension to declare an abstract method
dart-lang/sdk@28962e1e80 Support static fields in extensions
dart-lang/sdk@7cadd70696 Fix language_2/ct_const_test
dart-lang/sdk@a917043332 APIs for editing Flutter widget properties.
dart-lang/sdk@09b93b7ea0 [fasta] Tweak fasta unit tests setup in anticipation of constant update 2018
dart-lang/sdk@3c3dc09d47 Test that ! on void is a compile time error
dart-lang/sdk@7139a2ab3a [vm] Fix function resolution so that it stops when it finds target even if it can't add method extractor.
dart-lang/sdk@d1bd3a2f43 [gardening] Fix language_2/generic_instanceof2_test
dart-lang/sdk@3dcaea5a25 [vm/aot/tfa] Update TFA unit tests to work with constants-update-2018
dart-lang/sdk@e95b1f7bf0 Make UNNECESSARY_NULL_AWARE_CALL a warning
dart-lang/sdk@2c26ece3cf [gardening] Fix non-web-integer in corelib_2/num_parse_test
dart-lang/sdk@1eb1520702 [vm/bytecode] Prevent triggering optimizing compilation from interpreter
dart-lang/sdk@ed764e5688 [gardening] Delete legacy parser_quirks_test
dart-lang/sdk@723bb0eee1 [dartdevc] make nullable_inference_test resilient to const refactor
dart-lang/sdk@f521f38b57 [vm/kernel] Handle InvalidExpression in constant contexts
dart-lang/sdk@0c9abb8816 [vm/ffi] Support structs on 32bit architectures
dart-lang/sdk@25bac04503 [tests] Delete temporary const tests
dart-lang/sdk@f40aac1b75 [cfe] Move general testcases into general/ subfolder
dart-lang/sdk@14ea27e65b [vm/concurrency] Make thread_registry not depend on [Isolate], move mutator thread from thread registry to isolate
dart-lang/sdk@97587b554f Update the element model to support extension methods
dart-lang/sdk@a8331cd109 Remove the STRONG_MODE_ prefix from error codes
dart-lang/sdk@4c5028d139 [vm/concurrency] Make an IsolateGroup object which will contain group-specific resources
@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 15, 2019

Checks failed, abandoning roll.

@bkonyi bkonyi closed this Jul 15, 2019
@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 15, 2019

Canceled by roller, abandoning roll.

@bkonyi bkonyi deleted the dart-sdk-roll-2019-07-15 branch July 15, 2019 17:51
@bkonyi bkonyi restored the dart-sdk-roll-2019-07-15 branch July 15, 2019 19:21
@bkonyi bkonyi reopened this Jul 15, 2019
@bkonyi bkonyi merged commit e105a89 into master Jul 15, 2019
@bkonyi bkonyi deleted the dart-sdk-roll-2019-07-15 branch July 15, 2019 19:21
@chinmaygarde
Copy link
Member

This seems to have caused LUCI failures on iOS 32 bit ARM builds.

@bkonyi bkonyi restored the dart-sdk-roll-2019-07-15 branch July 15, 2019 20:18
bkonyi added a commit that referenced this pull request Jul 15, 2019
bkonyi added a commit that referenced this pull request Jul 15, 2019
@bkonyi bkonyi deleted the dart-sdk-roll-2019-07-15 branch July 15, 2019 20:18
@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 15, 2019

This seems to have caused LUCI failures on iOS 32 bit ARM builds.

Ah shoot, sorry about that. Thanks for pointing it out. I've reverted the roll.

engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 15, 2019
flutter/engine@76a91d3...3f27c57

git log 76a91d3..3f27c57 --no-merges --oneline
3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830)
eb4793a Revert "Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (#9826)" (flutter/engine#9829)
9c54621 bitcode (flutter/engine#9823)
e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826)
2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827)
418fe5b Document FontFeature class (flutter/engine#9808)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@76a91d3...3f27c57

git log 76a91d3..3f27c57 --no-merges --oneline
3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830)
eb4793a Revert &flutter#34;Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter#9826)&flutter#34; (flutter/engine#9829)
9c54621 bitcode (flutter/engine#9823)
e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826)
2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827)
418fe5b Document FontFeature class (flutter/engine#9808)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants