Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate the plugins .java/.h/.m files outside of user source directories #9826

Open
xster opened this issue May 5, 2017 · 2 comments
Open

Generate the plugins .java/.h/.m files outside of user source directories #9826

xster opened this issue May 5, 2017 · 2 comments
Labels
customer: crowd Affects or could affect many people, though not necessarily a specific customer. dependency: android Android team may need to help us P2 Important issues not at the top of the work list platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android t: xcode "xcodebuild" on iOS and general Xcode project management team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-android Triaged by Android platform team

Comments

@xster
Copy link
Member

xster commented May 5, 2017

Let's move various codegen'ed outputs into the /build directory of the project instead of /android or /ios folders so that they're not user visible, or checked in-able, flutter created, or in the example projects.

This is mostly consistent with codegen'ed frameworks such as dagger to not let intermediate code be user visible but not meaningfully editable.

cc @cbracken
@xster xster mentioned this issue May 5, 2017
Merged
@Hixie Hixie added the plugin label May 23, 2017
@amirh amirh removed the plugin label Mar 29, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Jul 15, 2019
@engine-flutter-autoroll
eb4793a Revert "Roll src/third_party/dart 24725a8559..cbaf890f88 (33 …
bde9654 
…commits) (flutter#9826)" (flutter/engine#9829)
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Jul 15, 2019
@engine-flutter-autoroll
eb4793a Revert "Roll src/third_party/dart 24725a8559..cbaf890f88 (33 …
7189350 
…commits) (flutter#9826)" (flutter/engine#9829)
Merged
engine-flutter-autoroll added a commit that referenced this issue Jul 15, 2019
@engine-flutter-autoroll
Roll engine 76a91d3..3f27c57 (6 commits) (#36216)
8ec730c 
flutter/engine@76a91d3...3f27c57

git log 76a91d3..3f27c57 --no-merges --oneline
3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830)
eb4793a Revert "Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (#9826)" (flutter/engine#9829)
9c54621 bitcode (flutter/engine#9823)
e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826)
2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827)
418fe5b Document FontFeature class (flutter/engine#9808)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this issue Jul 30, 2019
@engine-flutter-autoroll @johnsonmh
Roll engine 76a91d3..3f27c57 (6 commits) (flutter#36216)
407259f 
flutter/engine@76a91d3...3f27c57

git log 76a91d3..3f27c57 --no-merges --oneline
3f27c57 Roll fuchsia/sdk/core/mac-amd64 from pU_n3ahOhH6HJhE4vs5pUR8cg5U22TItP_Ds_N2OXPIC to qFyiJ56_6XZ5fjNssdCk_vOtBHg4YdWAPNeMIAf07-gC (flutter/engine#9830)
eb4793a Revert &flutter#34;Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter#9826)&flutter#34; (flutter/engine#9829)
9c54621 bitcode (flutter/engine#9823)
e105a89 Roll src/third_party/dart 24725a8559..cbaf890f88 (33 commits) (flutter/engine#9826)
2e83c4a Roll fuchsia/sdk/core/linux-amd64 from ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC to IPgI5Uh4rIZ4zNfAV1_ynC4dGmFLexAW1L9czHUyjowC (flutter/engine#9827)
418fe5b Document FontFeature class (flutter/engine#9808)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
@iapicca iapicca added the customer: crowd Affects or could affect many people, though not necessarily a specific customer. label Nov 1, 2019
@iapicca iapicca added framework flutter/packages/flutter repository. See also f: labels. p: tooling Affects the flutter_plugin_tools package plugin tool Affects the "flutter" command-line tool. See also t: labels. dependency: android Android team may need to help us t: gradle "flutter build" and "flutter run" on Android t: xcode "xcodebuild" on iOS and general Xcode project management platform-ios iOS applications specifically platform-android Android applications specifically labels Jan 6, 2020
@Hixie Hixie added this to the Goals milestone Jan 7, 2020
@jmagman jmagman removed framework flutter/packages/flutter repository. See also f: labels. p: tooling Affects the flutter_plugin_tools package plugin labels Feb 4, 2020
@iapicca iapicca removed the platform-ios iOS applications specifically label Mar 11, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@kf6gpe kf6gpe removed this from the Goals milestone Jun 2, 2020
@Hixie Hixie removed this from the Goals milestone Jun 2, 2020
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@blasten
Copy link

blasten commented May 7, 2021

Is this still the case @xster ? What are some examples?

@xster
Copy link
Member Author

xster commented May 7, 2021

Oh man, this is pretty old. I'm guessing I was thinking of the GeneratedPluginRegistrant file

@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer: crowd Affects or could affect many people, though not necessarily a specific customer. dependency: android Android team may need to help us P2 Important issues not at the top of the work list platform-android Android applications specifically t: gradle "flutter build" and "flutter run" on Android t: xcode "xcodebuild" on iOS and general Xcode project management team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@stuartmorgan @xster @Hixie @jmagman @amirh @blasten @kf6gpe @iapicca