Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Remove bitcode support on iOS #107887

Closed
15 of 17 tasks
jmagman opened this issue Jul 19, 2022 · 6 comments
Closed
15 of 17 tasks

☂️ Remove bitcode support on iOS #107887

jmagman opened this issue Jul 19, 2022 · 6 comments
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@jmagman
Copy link
Member

jmagman commented Jul 19, 2022

Apple is dropping support for bitcode submissions in Xcode 14/iOS 16. Remove it from Flutter.

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.

Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)

https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

Note Apple never used bitcode on macOS so this only impacts iOS.
See #15288 for breadcrumbs of what needs to be removed.

@jmagman
Copy link
Member Author

jmagman commented Jul 19, 2022

@dnfield am I missing anything? Can any LTO logic also be removed?

@flutter flutter locked as off-topic and limited conversation to collaborators Jul 19, 2022
@flutter flutter unlocked this conversation Jul 19, 2022
@jmagman
Copy link
Member Author

jmagman commented Jul 19, 2022

cc @mraleph

@dnfield
Copy link
Contributor

dnfield commented Jul 19, 2022

This looks good to me

@jmagman
Copy link
Member Author

jmagman commented Oct 7, 2022

The user-facing parts of this are done. Flutter projects with bitcode on should now be off. Flutter frameworks are no longer built with bitcode. Some documentation has been updated to note that bitcode is no longer supported.

Goma has been turned on in the iOS framework engine builders and are now significantly faster.

Still need to move the roll scriptoff the ios-release-nobitcode, and announce this in the next release blog post.

@jmagman
Copy link
Member Author

jmagman commented Oct 18, 2022

The code part of this is complete and will be available in the next stable, the rest is housekeeping. Closing.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
Development

No branches or pull requests

4 participants