Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Run windows_arm build only on main branch. #40546

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Run windows_arm build only on main branch. #40546

merged 3 commits into from
Mar 22, 2023

Conversation

godofredoc
Copy link
Contributor

Dart SDK does not exist in beta or stable branches. This PR will limit the execution of this build to main branch only.

Bug: flutter/flutter#123288

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Dart SDK does not exist in beta or stable branches. This PR will limit
the execution of this build to main branch only.

Bug: flutter/flutter#123288
@godofredoc godofredoc requested a review from itsjustkevin March 22, 2023 22:42
@loic-sharma
Copy link
Member

@godofredoc Could you expand on why this is necessary? Is Dart's support for Windows ARM disabled on stable and beta? Does that mean that Flutter stable and beta won't be able to support Windows ARM? /cc @pbo-linaro

@godofredoc
Copy link
Contributor Author

@godofredoc Could you expand on why this is necessary? Is Dart's support for Windows ARM disabled on stable and beta? Does that mean that Flutter stable and beta won't be able to support Windows ARM? /cc @pbo-linaro

That is correct, this is the initial bug: flutter/flutter#113931

The TLDR; is that Dart SDK support for windows arm is considered experimental and not currently shipped to beta or stable channels.

itsjustkevin pushed a commit that referenced this pull request Mar 23, 2023
Run windows_arm build only on main branch.
@pbo-linaro
Copy link
Contributor

pbo-linaro commented Mar 24, 2023

And do you think it could be possible to collaborate with Dart team to enable this, with Flutter dev team support?

@godofredoc
Copy link
Contributor Author

cc'ing @timsneath who can provide more info about the dart sdk windows arm strategy.

@timsneath
Copy link
Contributor

We are super-excited for the (Flutter, Windows, ARM) tuple to be checked! (I'm particularly excited -- I have more ARM than Intel machines running Windows...)

As I understand it, the lay of the land is that we're still standing up our test CI infrastructure to fully support ARM: we have an array of Volterra devices that will be up and running in the next couple of months. When we have that enabled, we'll have the infrastructure to be able to consistently run test suites on Windows/ARM, which is a prerequisite to us being able to declare beta or stable. And yes -- it's of course our goal that Flutter supports Windows/ARM, thanks in large part to your contributions.

While we get the test labs spun up, we'd be delighted to see you continue to work on proving this out on the master channel, so that we're ready as soon as possible. Excited to make some noise about this!

@pbo-linaro
Copy link
Contributor

pbo-linaro commented Mar 27, 2023

Good to hear you're on track to support Windows on Arm with dedicated machines 👍.
For now, at Flutter level, we can enable it for master channel only, and later, to beta and stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants