Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Create a fixed-stop gradient variant for SSBOs #119365

Closed
jonahwilliams opened this issue Jan 27, 2023 · 2 comments
Closed

[Impeller] Create a fixed-stop gradient variant for SSBOs #119365

jonahwilliams opened this issue Jan 27, 2023 · 2 comments
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jonahwilliams
Copy link
Member

In order to support arbitrary stops, the gradient fragment shaders interate over the stop data (see flutter/engine#39174). This is more expensive than it needs to be in cases where we know the stops are evenly spaced - the exact colors can be looked up and lerp'd. We can quickly compute this in the entity contents and set a uniform value and branch, but today that will likely lead to most shaders executing both branches.

This should be done with shader variants following #119357

@jonahwilliams jonahwilliams added engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list e: impeller Impeller rendering backend issues and features requests labels Jan 27, 2023
@chinmaygarde chinmaygarde changed the title [impeller] create a fixed-stop gradient variant for SSBOs [impeller] Create a fixed-stop gradient variant for SSBOs Feb 2, 2023
@chinmaygarde chinmaygarde changed the title [impeller] Create a fixed-stop gradient variant for SSBOs [Impeller] Create a fixed-stop gradient variant for SSBOs Feb 2, 2023
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
@jonahwilliams
Copy link
Member Author

Despite looking at a lot of different apps with large gradients, this has never been a problem. probably not worth a specific variant.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant