Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] support overlapping stops with SSBO gradients. #39174

Merged
merged 14 commits into from Jan 27, 2023
Merged

[Impeller] support overlapping stops with SSBO gradients. #39174

merged 14 commits into from Jan 27, 2023

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jan 26, 2023 •
edited

Makes the gradient shaders more expensive, but fully supports overlapping stops and reduces CPU workload. This can be clawed back later via shader variants.

Fixes flutter/flutter#119175

overlapping

@jonahwilliams jonahwilliams self-assigned this Jan 26, 2023
chinmaygarde
chinmaygarde approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a framework for reasoning about how much more expensive this is. But seems like a fine tradeoff.

@jonahwilliams
Copy link
Member Author

@zanderso when's malioc?

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2023
@auto-submit auto-submit bot merged commit 8567d96 into flutter:main Jan 27, 2023
@zanderso
Copy link
Member

@zanderso when's malioc?

If you have a local install you can follow the instructions on the PR here #39005. As for when we can get it in CI, that is going to be possible, but there's some paperwork to do that I need to prioritize.

@jonahwilliams jonahwilliams deleted the gradient_with_stps branch January 27, 2023 19:37
@jonahwilliams jonahwilliams mentioned this pull request Jan 27, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2023
@engine-flutter-autoroll
8567d9699 [Impeller] support overlapping stops with SSBO gradients. (f…
2a8c100 
…lutter/engine#39174)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2023
@engine-flutter-autoroll
Roll Flutter Engine from b32fc7fef208 to 8567d96993ed (5 revisions) (#…
ab2232a 
…119369)

* ab1eda7c7 Handle proto deps that were added to the Dart SDK (flutter/engine#39098)

* 70f96af0a [impellerc] remove coffset usage (flutter/engine#39199)

* 4bab18407 [impellerc] remove remaining remap sampler support (flutter/engine#39198)

* a1e657a1e Move Linux Fuchsia FEMU to bringup due to flakes (flutter/engine#39202)

* 8567d9699 [Impeller] support overlapping stops with SSBO gradients. (flutter/engine#39174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@bdero bdero Awaiting requested review from bdero

Assignees

@jonahwilliams jonahwilliams

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
3 participants
@jonahwilliams @zanderso @chinmaygarde